You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@marvin.apache.org by GitBox <gi...@apache.org> on 2021/09/08 12:32:25 UTC
[GitHub] [incubator-marvin] cardosolucas opened a new pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
cardosolucas opened a new pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57
Some integrations and CLI commands for modern tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] cardosolucas closed pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
cardosolucas closed pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] Wei-1 commented on pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
Wei-1 commented on pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#issuecomment-916258252
I think it will definitely be better if we close this and open several new PRs.
But it depends on your time and resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] Wei-1 commented on a change in pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
Wei-1 commented on a change in pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#discussion_r704554274
##########
File path: python-daemon/setup.py
##########
@@ -75,6 +75,8 @@
'idna>=2.5',
'bleach>=1.5.0',
'pyspark',
+ 'tensorflow==2.3',
Review comment:
Also, we also see `This package requires Rust >=1.41.0.` in the error log, and is requesting us to run `pip install --upgrade pip`.
We should simply upgrade the `pip` in the daemon and both error should be solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] Wei-1 commented on pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
Wei-1 commented on pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#issuecomment-915362001
Also, I would like to know if there are separated commits so that we can separate all these dependencies bump and feature adding into several PRs.
It will be a lot easier to debug and review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] cardosolucas commented on pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
cardosolucas commented on pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#issuecomment-916339829
It's fine for me. You can close this one. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] cardosolucas commented on pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
cardosolucas commented on pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#issuecomment-916251596
Do you prefer to close this PR so I can commit each feature independently? I can do it this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] Wei-1 commented on a change in pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
Wei-1 commented on a change in pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#discussion_r704550477
##########
File path: python-daemon/setup.py
##########
@@ -75,6 +75,8 @@
'idna>=2.5',
'bleach>=1.5.0',
'pyspark',
+ 'tensorflow==2.3',
Review comment:
This dependency is causing error during test: https://app.travis-ci.com/github/apache/incubator-marvin/jobs/536187758
Might need to point the `pip` to the correct artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] Wei-1 commented on a change in pull request #57: Adding kubernetes, docker templates, TFX support and steroids on CLI
Posted by GitBox <gi...@apache.org>.
Wei-1 commented on a change in pull request #57:
URL: https://github.com/apache/incubator-marvin/pull/57#discussion_r704550477
##########
File path: python-daemon/setup.py
##########
@@ -75,6 +75,8 @@
'idna>=2.5',
'bleach>=1.5.0',
'pyspark',
+ 'tensorflow==2.3',
Review comment:
This dependency is cause error during test: https://app.travis-ci.com/github/apache/incubator-marvin/jobs/536187758
Might need to point the `pip` to the correct artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@marvin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org