You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/01 17:34:32 UTC
[GitHub] [tvm] areusch opened a new pull request, #11988: Couple patches to docker/bash.sh after #11976.
areusch opened a new pull request, #11988:
URL: https://github.com/apache/tvm/pull/11988
* Use python3 to run determine_docker_images.py
* Properly detect presence of CI env var with + expansion.
@leandron @mehrdadh @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #11988: Couple patches to docker/bash.sh after #11976.
Posted by GitBox <gi...@apache.org>.
areusch merged PR #11988:
URL: https://github.com/apache/tvm/pull/11988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11988: Couple patches to docker/bash.sh after #11976.
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11988:
URL: https://github.com/apache/tvm/pull/11988#discussion_r912158854
##########
docker/bash.sh:
##########
@@ -290,10 +289,10 @@ DOCKER_DEVICES=( )
# If the user gave a shortcut defined in the Jenkinsfile, use it.
EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}")
if [ -n "${EXPANDED_SHORTCUT}" ]; then
- if [ "${CI+x}" == "true" ]; then
+ if [ "${CI+x}" == "x" ]; then
Review Comment:
this seems to detect `CI` set to anything, rather than just `true`, is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11988: Couple patches to docker/bash.sh after #11976.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11988:
URL: https://github.com/apache/tvm/pull/11988#issuecomment-1172672579
<!---docs-bot-comment-->
Built docs for commit d1a20bc9b7a7dd628d012fe5855ae1cdbb11686e can be found [here](https://pr-docs.tlcpack.ai/PR-11988/1/docs/index.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11988: Couple patches to docker/bash.sh after #11976.
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11988:
URL: https://github.com/apache/tvm/pull/11988#discussion_r912262725
##########
docker/bash.sh:
##########
@@ -290,10 +289,10 @@ DOCKER_DEVICES=( )
# If the user gave a shortcut defined in the Jenkinsfile, use it.
EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}")
if [ -n "${EXPANDED_SHORTCUT}" ]; then
- if [ "${CI+x}" == "true" ]; then
+ if [ "${CI+x}" == "x" ]; then
Review Comment:
with +x it merely evaluates to "x" if the var is set and nothing if not, iiuc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org