You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2023/09/19 10:02:58 UTC
[GitHub] [airflow] Lee-W commented on a diff in pull request #34404: Refactor import sqlalchemy as sa
Lee-W commented on code in PR #34404:
URL: https://github.com/apache/airflow/pull/34404#discussion_r1329882069
##########
airflow/settings.py:
##########
@@ -237,9 +237,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None):
session = Session()
try:
result = session.execute(
- sqlalchemy.text(
- "SELECT is_read_committed_snapshot_on FROM sys.databases WHERE name=:database_name"
- ),
+ sa.text("SELECT is_read_committed_snapshot_on FROM sys.databases WHERE name=:database_name"),
Review Comment:
Second with @Taragolis 's thoughts. Or should we use `import sqlalchemy` instead of `from sqlalchemy import ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org