You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/06/09 16:53:58 UTC

[GitHub] [flink] zentol opened a new pull request, #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

zentol opened a new pull request, #22753:
URL: https://github.com/apache/flink/pull/22753

   These dependencies are not required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22753:
URL: https://github.com/apache/flink/pull/22753#discussion_r1228245771


##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -136,21 +123,11 @@ under the License.
 
 	<dependencyManagement>
 		<dependencies>
-			<dependency>
-				<groupId>org.scala-lang</groupId>
-				<artifactId>scala-compiler</artifactId>
-				<version>${scala.version}</version>
-			</dependency>
 			<dependency>
 				<groupId>org.scala-lang</groupId>
 				<artifactId>scala-library</artifactId>

Review Comment:
   This is required by Akka since it's written in Scala ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22753:
URL: https://github.com/apache/flink/pull/22753#discussion_r1228288172


##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -136,21 +123,11 @@ under the License.
 
 	<dependencyManagement>
 		<dependencies>
-			<dependency>
-				<groupId>org.scala-lang</groupId>
-				<artifactId>scala-compiler</artifactId>
-				<version>${scala.version}</version>
-			</dependency>
 			<dependency>
 				<groupId>org.scala-lang</groupId>
 				<artifactId>scala-library</artifactId>

Review Comment:
   We need to overwrite the version here else we'd pull in what the parent pom declares (2.12.7)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22753:
URL: https://github.com/apache/flink/pull/22753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on a diff in pull request #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22753:
URL: https://github.com/apache/flink/pull/22753#discussion_r1228225178


##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -136,21 +123,11 @@ under the License.
 
 	<dependencyManagement>
 		<dependencies>
-			<dependency>
-				<groupId>org.scala-lang</groupId>
-				<artifactId>scala-compiler</artifactId>
-				<version>${scala.version}</version>
-			</dependency>
 			<dependency>
 				<groupId>org.scala-lang</groupId>
 				<artifactId>scala-library</artifactId>

Review Comment:
   Why do we need `scala-library` still as a dependency here? :thinking: There are no sub-modules that could use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22753: [FLINK-32304] Reduce rpc-akka dependency footprint

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22753:
URL: https://github.com/apache/flink/pull/22753#issuecomment-1584891328

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84192cf3cb3f73b28dcab1fcdbb2640ec722f13a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "84192cf3cb3f73b28dcab1fcdbb2640ec722f13a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84192cf3cb3f73b28dcab1fcdbb2640ec722f13a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org