You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 15:03:44 UTC

[GitHub] [airflow] gitstart-airflow opened a new pull request, #22951: Refactor airbyte provider tests to use assert_has_calls

gitstart-airflow opened a new pull request, #22951:
URL: https://github.com/apache/airflow/pull/22951

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

related: [20453](https://github.com/apache/airflow/issues/20453)
This PR provides test fixes for the issue listed on #20453. The fix is for the Airbyte provider only.

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #22951: Refactor airbyte provider tests to use assert_has_calls

Posted by GitBox <gi...@apache.org>.

uranusjr commented on code in PR #22951:
URL: https://github.com/apache/airflow/pull/22951#discussion_r848572271


##########
tests/providers/airbyte/hooks/test_airbyte.py:
##########
@@ -98,20 +98,20 @@ def test_wait_for_job_incomplete_succeeded(self, mock_get_job):
         self.hook.wait_for_job(job_id=self.job_id, wait_seconds=0)
 
         calls = [mock.call(job_id=self.job_id), mock.call(job_id=self.job_id)]
-        assert mock_get_job.has_calls(calls)
+        mock_get_job.assert_has_calls(calls)
 
     @mock.patch('airflow.providers.airbyte.hooks.airbyte.AirbyteHook.get_job')
     def test_wait_for_job_timeout(self, mock_get_job):
         mock_get_job.side_effect = [
             self.return_value_get_job(self.hook.PENDING),
             self.return_value_get_job(self.hook.RUNNING),
-            self.return_value_get_job(self.hook.RUNNING),
         ]
         with pytest.raises(AirflowException, match="Timeout"):
             self.hook.wait_for_job(job_id=self.job_id, wait_seconds=2, timeout=1)
 
-        calls = [mock.call(job_id=self.job_id), mock.call(job_id=self.job_id), mock.call(job_id=self.job_id)]
-        assert mock_get_job.has_calls(calls)
+        calls = [mock.call(job_id=self.job_id)]
+        mock_get_job.assert_has_calls(calls)
+        assert mock_get_job.call_count == 1

Review Comment:
   ```suggestion
           assert mock_get_job.mock_calls == calls
   ```
   
   Succinct and clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #22951: Refactor airbyte provider tests to use assert_has_calls

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #22951:
URL: https://github.com/apache/airflow/pull/22951#issuecomment-1097158026

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #22951: Refactor airbyte provider tests to use assert_has_calls

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #22951:
URL: https://github.com/apache/airflow/pull/22951


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org