[Bug 4058] [review] Feature Request: whitelist_subject and blacklist_subject

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=4058


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW




------- Additional Comments From jm@jmason.org  2005-01-16 17:24 -------
> [X] Include this plugin, but also move all of the whitelist/blacklist_* stuff
> into the plugin.

+1 for me too.  and enable it by default ;)


Loren -- IMO, if any code is moved from the existing code into a plugin, that by
definition needs to be one of the default-enabled plugins for future releases
(unless there's a very good reason otherwise).

------- Additional Comments From jm@jmason.org  2005-01-16 17:24 -------
> [X] Include this plugin, but also move all of the whitelist/blacklist_* stuff
> into the plugin.

+1 for me too.  and enable it by default ;)


Loren -- IMO, if any code is moved from the existing code into a plugin, that by
definition needs to be one of the default-enabled plugins for future releases
(unless there's a very good reason otherwise).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug 4058] [review] Feature Request: whitelist_subject and blacklist_subject

[Michael Parker <pa...@pobox.com>]

> 
> ------- Additional Comments From jm@jmason.org  2005-01-16 17:24 -------
> > [X] Include this plugin, but also move all of the whitelist/blacklist_* stuff
> > into the plugin.
> 
> +1 for me too.  and enable it by default ;)


I actually have a new proposal.  Not totally sure how it all fits, but
it's something I think we should address.

In working with the History Plugin to replace AWL there is an aspect
of those modules that behaves exactly like whitelist_from and
blacklist_from when you add an address to the blacklist/whitelist.

I'll use AWL since that is what people know.  When you add an address
either to the whitelist or blacklist in AWL it just adds a generic
(addr only, no associated IP) entry to the database with either a -100
or 100 score.  Once a msg is received for that address then the entry
is "upgraded" to include the IP and the average score starts moving
either up or down, depending on the type of msgs.  So, if you have
foo@example.com spamming you with low scoring msgs and add them to
your AWL blacklist, eventually their AWL score will be low enough to
not be caught.  In addition, if they start spamming from a different
IP range then the whole process starts all over again.

I'm adding the concept of user added entries to the History plugin.
These are entries that once added will not have their scores modified,
either up or down and will never have an associated IP.  This will in
effect work exactly like whitelist_from and blacklist_from.  And of
course the two now collide in a slightly non-obvious way (there has
always been some error of confusion with the whole
--add-addr-to-whitelist, etc. commands anyway).

I propose that we merge this functionality in some way.  Removing the
"user added" whitelist/blacklist entries from History/AWL and make
that the sole domain of the whitelist plugin.  This would mean some
sort of work to store entries added from the command line in a
database.  Possibly storing all of the entries in a database, removing
the ability to put whitelist_* and blacklist_* entries in cf or
user_prefs files.

This is possibly something more suited for a later (ie 4.0) release.
But wanted to toss the idea out to see what people thought.  I'm more
interested in doing something in this area to help remove confusion
with this whole set of options in spamassassin:

        -W, --add-to-whitelist            Add addresses in mail to whitelist (AWL)
        --add-to-blacklist                Add addresses in mail to blacklist (AWL)
        -R, --remove-from-whitelist       Remove all addresses found in mail
                                          from whitelist (AWL)
        --add-addr-to-whitelist=addr      Add addr to whitelist (AWL)
        --add-addr-to-blacklist=addr      Add addr to blacklist (AWL)
        --remove-addr-from-whitelist=addr Remove addr from whitelist (AWL)


And am open to other ideas.  BTW, all of the above options now have
associated Plugin hooks, so we are pretty flexible with what actually
handles them.

Michael