You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/01/25 21:19:14 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8239: Remove use of IPv[4|6]BUF macro from net/slip

pkarashchenko commented on code in PR #8239:
URL: https://github.com/apache/nuttx/pull/8239#discussion_r1087185294


##########
drivers/net/slip.c:
##########
@@ -109,6 +109,11 @@
 
 #define SLIP_WDDELAY   (1*1000000)
 
+/* This is a helper pointer for accessing the contents of the ip header */
+
+#define IPv4HDR        ((FAR struct ipv4_hdr_s *)priv->dev.d_buf)

Review Comment:
   Maybe similar change is need in `tun.c`. @anchao could you please take a look?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org