You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/05 13:10:27 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
ephraimbuddy opened a new pull request #16816:
URL: https://github.com/apache/airflow/pull/16816
This change moves the AbstractDagFileProcessorProcess to processor.py so that it's in the same file with DagFileProcessorProcess
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874107696
Why do we need this abstract base class in the first place? Do we support plugins to swap out `process_factory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874110978
> Why do we need this abstract base class in the first place? Do we support plugins to swap out `process_factory`?
I don't think there's such support for plugins @kaxil @ashb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874107696
Why do we need this abstract base class in the first place? Do we support plugins to swap out `process_factory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #16816: Remove AbstractDagFileProcessorProcess from dag processing
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #16816:
URL: https://github.com/apache/airflow/pull/16816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #16816: Remove AbstractDagFileProcessorProcess from dag processing
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #16816:
URL: https://github.com/apache/airflow/pull/16816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874354879
This is a relic of a previous pattern caused by a misunderstanding of multiprocessing.
Remove the base class entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16816: Remove AbstractDagFileProcessorProcess from dag processing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874590039
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874110978
> Why do we need this abstract base class in the first place? Do we support plugins to swap out `process_factory`?
I don't think there's such support for plugins @kaxil @ashb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16816: Move AbstractDagFileProcessorProcess to processor.py
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874354879
This is a relic of a previous pattern caused by a misunderstanding of multiprocessing.
Remove the base class entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16816: Remove AbstractDagFileProcessorProcess from dag processing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16816:
URL: https://github.com/apache/airflow/pull/16816#issuecomment-874590039
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org