You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Paul Gier (JIRA)" <ji...@codehaus.org> on 2008/02/14 00:47:28 UTC
[jira] Created: (MASSEMBLY-282) Fix failing IT
no-appendAssemblyId-no-classifier
Fix failing IT no-appendAssemblyId-no-classifier
------------------------------------------------
Key: MASSEMBLY-282
URL: http://jira.codehaus.org/browse/MASSEMBLY-282
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Reporter: Paul Gier
Attachments: maven-assembly-plugin-AddDependencySetsTask.patch
The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-282) Fix failing IT
no-appendAssemblyId-no-classifier
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MASSEMBLY-282:
--------------------------------
Attachment: maven-assembly-plugin-AddArtifactTask-improved.patch
I'm attaching what I think is a slightly improved patch. This one modifies the class AddArtifactTask. This catches more scenarios in which the archiver tries to add an archive to itself.
> Fix failing IT no-appendAssemblyId-no-classifier
> ------------------------------------------------
>
> Key: MASSEMBLY-282
> URL: http://jira.codehaus.org/browse/MASSEMBLY-282
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Reporter: Paul Gier
> Attachments: maven-assembly-plugin-AddArtifactTask-improved.patch, maven-assembly-plugin-AddDependencySetsTask.patch
>
>
> The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
> The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-282) Fix failing IT
no-appendAssemblyId-no-classifier
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-282.
--------------------------------
Resolution: Fixed
I modified the patch to copy the conflicting file to a temporary location then include it from there, rather than skipping it entirely. This supports the use case where the assembly plugin is used to post-process the output artifact for a build, but that post-processing is meant to include the main artifact's contents.
> Fix failing IT no-appendAssemblyId-no-classifier
> ------------------------------------------------
>
> Key: MASSEMBLY-282
> URL: http://jira.codehaus.org/browse/MASSEMBLY-282
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Reporter: Paul Gier
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: maven-assembly-plugin-AddArtifactTask-improved.patch, maven-assembly-plugin-AddDependencySetsTask.patch
>
> Original Estimate: 0 minutes
> Remaining Estimate: 0 minutes
>
> The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
> The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-282) Fix failing IT
no-appendAssemblyId-no-classifier
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123722 ]
Paul Gier commented on MASSEMBLY-282:
-------------------------------------
Ok, that makes sense. Thanks for fixing this.
> Fix failing IT no-appendAssemblyId-no-classifier
> ------------------------------------------------
>
> Key: MASSEMBLY-282
> URL: http://jira.codehaus.org/browse/MASSEMBLY-282
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Reporter: Paul Gier
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: maven-assembly-plugin-AddArtifactTask-improved.patch, maven-assembly-plugin-AddDependencySetsTask.patch
>
> Original Estimate: 0 minutes
> Remaining Estimate: 0 minutes
>
> The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
> The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-282) Fix failing IT
no-appendAssemblyId-no-classifier
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-282:
---------------------------------
Assignee: John Casey
Description:
The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
was:
The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
Fix Version/s: 2.2-beta-2
Remaining Estimate: 0 minutes
Original Estimate: 0 minutes
> Fix failing IT no-appendAssemblyId-no-classifier
> ------------------------------------------------
>
> Key: MASSEMBLY-282
> URL: http://jira.codehaus.org/browse/MASSEMBLY-282
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Reporter: Paul Gier
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: maven-assembly-plugin-AddArtifactTask-improved.patch, maven-assembly-plugin-AddDependencySetsTask.patch
>
> Original Estimate: 0 minutes
> Remaining Estimate: 0 minutes
>
> The IT no-appendAssemblyId-no-classifier is currently failing. This is due to the fact that the dependency set task tries to include the main project artifact as one of the dependencies. This causes a problem when there is no assembly ID and no classifier, because the archiver tries to include the destination file for the assembly in itself.
> The patch adds a check to make sure the archiver destination file does not get included as one of the entries. The patch also includes updates to the unit tests to reflect the new behaviour of the AddDependencySetsTask.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira