[GitHub] [beam] scwhittle commented on a diff in pull request #27032: Change default work remaining to 0.0 instead of 1.0

["scwhittle (via GitHub)" <gi...@apache.org>]

scwhittle commented on code in PR #27032:
URL: https://github.com/apache/beam/pull/27032#discussion_r1229242205


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java:
##########
@@ -432,7 +432,7 @@ public static <InputT, OutputT> double invokeGetSize(
             .getProgress()
             .getWorkRemaining();
       } else {
-        return 1.0;
+        return 0.0;

Review Comment:
   Please update the comment where the interface is defined, as it explicitly states 1.0.  The comment requested above would be better there too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org