[GitHub] john-bodley opened a new pull request #5256: [slice] Adding slice owners to SliceFilter

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #5256: [slice] Adding slice owners to SliceFilter
URL: https://github.com/apache/incubator-superset/pull/5256
 
 
   Similar to https://github.com/apache/incubator-superset/pull/4520 this PR adds owners of a slice to the `SliceFilter` method which ensures that owners can view the slices they own irrelevant of the permission. 
   
   Note this really is a temporary partial fix as the current `DashboardFilter`, `DatasourceFilter`, and `SliceFilter` do not currently correctly apply the correct permission logic, i.e., for users without all-datasource-access the filters merely check if the corresponding datasource permission is explicitly defined for their roles, however it does not take into account indirect schema access, database access etc.
   
   to: @graceguo-supercat @jeffreythewang @michellethomas @mistercrunch @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org