[jira] [Work logged] (GOBBLIN-1537) use DatasetHandlerService to customize trash location

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1537?focusedWorklogId=647652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647652 ]

ASF GitHub Bot logged work on GOBBLIN-1537:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Sep/21 00:45
            Start Date: 08/Sep/21 00:45
    Worklog Time Spent: 10m 
      Work Description: aplex commented on a change in pull request #3387:
URL: https://github.com/apache/gobblin/pull/3387#discussion_r703942804



##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/Trash.java
##########
@@ -94,6 +97,8 @@ public Path getTrashLocation() throws IOException {
    */
   protected Path createTrashLocation(FileSystem fs, Properties props, String user) throws IOException {
     Path trashLocation;
+    new DestinationDatasetHandlerService(new State(props), false, null)

Review comment:
       What will this do? Add something to props? Can we get the trash folder or dataset root folder directly, through the statically-typed APIs, instead of a global collection of props?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 647652)
    Remaining Estimate: 0h
            Time Spent: 10m

> use DatasetHandlerService to customize trash location
> -----------------------------------------------------
>
>                 Key: GOBBLIN-1537
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1537
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)