[GitHub] [lucene] mikemccand commented on pull request #191: LUCENE-9964: Duplicate long values in a field should only be counted once when using SortedNumericDocValuesFields

[GitBox <gi...@apache.org>]

mikemccand commented on pull request #191:
URL: https://github.com/apache/lucene/pull/191#issuecomment-873625996


   > @mikemccand I'm curious about your suggestion to squash these duplicates at indexing time. Are we certain there aren't any valid use-cases for indexing duplicate longs into the same field for a single document? If that's the case, should we open an issue to enforce this at indexing time? That would indeed remove the need for this bug-fix. That said, I'm still in favor of fixing this bug now at query/faceting time (thanks for taking this up @gautamworah96!). As long as duplicate long values are allowed, we should make sure our facet counting logic handles them appropriately.
   
   Yeah +1 to make this first (query-time) fix, now, and separately to provide a simple option to dedup your doc-values field during indexing.
   
   I agree there may be real use cases for preserving  duplicates, so both options would be great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org