[jira] [Commented] (SCB-601) ServiceComb integrated to spring boot or tomcat will print too many logs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497447#comment-16497447 ] 

ASF GitHub Bot commented on SCB-601:
------------------------------------

WillemJiang commented on a change in pull request #743: [SCB-601] when java.lang.Error: not support def type: class io.swagger.models.ComposedMode we don't know which swagger
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/743#discussion_r192278923
 
 

 ##########
 File path: swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/SwaggerUtils.java
 ##########
 @@ -67,6 +71,27 @@ public static Swagger parseSwagger(String swaggerContent) {
     }
   }
 
+  /**
+   * Provide a method to validate swagger. This method is now implemented to check common errors, and the logic
+   * will be changed when necessary. For internal use only.
+   */
+  public static void invalidateSwagger(Swagger swagger) {
 
 Review comment:
   the method name should be validateSwagger instead of invalidateSwagger.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ServiceComb integrated to spring boot or tomcat will print too many logs
> ------------------------------------------------------------------------
>
>                 Key: SCB-601
>                 URL: https://issues.apache.org/jira/browse/SCB-601
>             Project: Apache ServiceComb
>          Issue Type: Task
>            Reporter: liubao
>            Assignee: liubao
>            Priority: Minor
>             Fix For: java-chassis-1.0.0-m2
>
>
> 2018-05-23 19:40:31.495 INFO 4812 --- [ntloop-thread-0] o.a.s.t.r.c.http.RestClientInvocation : http connection connected, local:192.168.0.204:59718, remote:192.168.0.204:7211.
> 2018-05-23 19:40:31.500 INFO 4812 --- [ntloop-thread-0] o.a.s.t.r.c.http.RestClientInvocation : http connection closed, local:192.168.0.204:59705, remote:192.168.0.204:7211.
> 2
>  
> In tomcat or some other HTTP short connections scenario, this logs comes too frequently/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)