You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/10/02 05:43:38 UTC
Review Request 68893: ATLAS-2905: Generate lineage information for
process entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68893/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2905
https://issues.apache.org/jira/browse/ATLAS-2905
Repository: atlas
Description
-------
Currently lineage information is generated only for DataSet entities and its derivatives. Lineage information should also be generated for Process entities and in UI lineage tab should be enabled for any process entities and lineage rendered.
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 47726aa6e
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 5d02ea541
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 82243ad2a
repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 9585a57a1
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8555b4c43
Diff: https://reviews.apache.org/r/68893/diff/1/
Testing
-------
Validated through REST:
curl -X GET http://ctr-e138-1518143905142-494504-01-000003.hwx.site:21000/api/atlas/v2/lineage/07050484-a2e7-4118-af2a-b59b39c3c0d5
Thanks,
Sarath Subramanian
Re: Review Request 68893: ATLAS-2905: Generate lineage information for
process entities
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68893/#review209160
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
Lines 110 (patched)
<https://reviews.apache.org/r/68893/#comment293452>
Consider replacing #110 - #114 with the following:
if (!isDataSet) {
boolean isProcess = entityType.getTypeAndAllSuperTypes().contains(PROCESS_SUPER_TYPE);
if (!isProcess) {
throw new AtlasBaseException(AtlasErrorCode.INVALID_LINEAGE_ENTITY_TYPE, guid, entity.getTypeName());
}
}
- Madhan Neethiraj
On Oct. 2, 2018, 5:43 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68893/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2018, 5:43 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2905
> https://issues.apache.org/jira/browse/ATLAS-2905
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently lineage information is generated only for DataSet entities and its derivatives. Lineage information should also be generated for Process entities and in UI lineage tab should be enabled for any process entities and lineage rendered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 47726aa6e
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 5d02ea541
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 82243ad2a
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 9585a57a1
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8555b4c43
>
>
> Diff: https://reviews.apache.org/r/68893/diff/1/
>
>
> Testing
> -------
>
> Validated through REST:
>
> curl -X GET http://ctr-e138-1518143905142-494504-01-000003.hwx.site:21000/api/atlas/v2/lineage/07050484-a2e7-4118-af2a-b59b39c3c0d5
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 68893: ATLAS-2905: Generate lineage information for
process entities
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68893/#review209161
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 2, 2018, 5:43 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68893/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2018, 5:43 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2905
> https://issues.apache.org/jira/browse/ATLAS-2905
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently lineage information is generated only for DataSet entities and its derivatives. Lineage information should also be generated for Process entities and in UI lineage tab should be enabled for any process entities and lineage rendered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 47726aa6e
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 5d02ea541
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 82243ad2a
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 9585a57a1
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8555b4c43
>
>
> Diff: https://reviews.apache.org/r/68893/diff/1/
>
>
> Testing
> -------
>
> Validated through REST:
>
> curl -X GET http://ctr-e138-1518143905142-494504-01-000003.hwx.site:21000/api/atlas/v2/lineage/07050484-a2e7-4118-af2a-b59b39c3c0d5
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 68893: ATLAS-2905: Generate lineage information for
process entities
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68893/
-----------------------------------------------------------
(Updated Oct. 2, 2018, 3:38 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-2905
https://issues.apache.org/jira/browse/ATLAS-2905
Repository: atlas
Description
-------
Currently lineage information is generated only for DataSet entities and its derivatives. Lineage information should also be generated for Process entities and in UI lineage tab should be enabled for any process entities and lineage rendered.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 47726aa6e
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 5d02ea541
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 82243ad2a
repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 9585a57a1
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8555b4c43
Diff: https://reviews.apache.org/r/68893/diff/2/
Changes: https://reviews.apache.org/r/68893/diff/1-2/
Testing
-------
Validated through REST:
curl -X GET http://ctr-e138-1518143905142-494504-01-000003.hwx.site:21000/api/atlas/v2/lineage/07050484-a2e7-4118-af2a-b59b39c3c0d5
Thanks,
Sarath Subramanian
Re: Review Request 68893: ATLAS-2905: Generate lineage information for
process entities
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68893/#review209147
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On Oct. 2, 2018, 5:43 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68893/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2018, 5:43 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2905
> https://issues.apache.org/jira/browse/ATLAS-2905
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently lineage information is generated only for DataSet entities and its derivatives. Lineage information should also be generated for Process entities and in UI lineage tab should be enabled for any process entities and lineage rendered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 47726aa6e
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 5d02ea541
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 82243ad2a
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 9585a57a1
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8555b4c43
>
>
> Diff: https://reviews.apache.org/r/68893/diff/1/
>
>
> Testing
> -------
>
> Validated through REST:
>
> curl -X GET http://ctr-e138-1518143905142-494504-01-000003.hwx.site:21000/api/atlas/v2/lineage/07050484-a2e7-4118-af2a-b59b39c3c0d5
>
>
> Thanks,
>
> Sarath Subramanian
>
>