You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/04 12:28:04 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #5462: Support multi bytes LineDelimiter and ColumnSeparator
yangzhg opened a new pull request #5462:
URL: https://github.com/apache/incubator-doris/pull/5462
[Internal][Support Multibytes Separator] doris-1079
support multi bytes LineDelimiter and ColumnSeparator
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If these changes need document changes, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #5462: [Load] Support multi bytes LineDelimiter and ColumnSeparator
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #5462:
URL: https://github.com/apache/incubator-doris/pull/5462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] mincwang commented on pull request #5462: [Load] Support multi bytes LineDelimiter and ColumnSeparator
Posted by GitBox <gi...@apache.org>.
mincwang commented on pull request #5462:
URL: https://github.com/apache/incubator-doris/pull/5462#issuecomment-918955066
@yangzhg Hi, can you help me look the problem. i think this is similar #6550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5462: [Load] Support multi bytes LineDelimiter and ColumnSeparator
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5462:
URL: https://github.com/apache/incubator-doris/pull/5462#discussion_r587521289
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -292,16 +304,24 @@ void BrokerScanner::close() {
}
void BrokerScanner::split_line(const Slice& line, std::vector<Slice>* values) {
- // line-begin char and line-end char are considered to be 'delimiter'
const char* value = line.data;
- const char* ptr = line.data;
- for (size_t i = 0; i < line.size; ++i, ++ptr) {
- if (*ptr == _value_separator) {
- values->emplace_back(value, ptr - value);
- value = ptr + 1;
+ size_t i = 0;
+ // TODO improve the performance
+ while (i < line.size) {
+ if (i + _value_separator.size() <= line.size) {
Review comment:
Does `_value_separator.size()` equals to `_value_separator_length`?
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -49,16 +49,28 @@ BrokerScanner::BrokerScanner(RuntimeState* state, RuntimeProfile* profile,
: BaseScanner(state, profile, params, pre_filter_ctxs, counter),
_ranges(ranges),
_broker_addresses(broker_addresses),
- // _splittable(params.splittable),
- _value_separator(static_cast<char>(params.column_separator)),
- _line_delimiter(static_cast<char>(params.line_delimiter)),
_cur_file_reader(nullptr),
_cur_line_reader(nullptr),
_cur_decompressor(nullptr),
_next_range(0),
_cur_line_reader_eof(false),
_scanner_eof(false),
- _skip_next_line(false) {}
+ _skip_next_line(false) {
+ if (params.__isset.column_separator_length && params.column_separator_length > 1) {
+ _value_separator = params.column_separator_str;
+ _value_separator_length = params.column_separator_length;
+ } else {
+ _value_separator.push_back(static_cast<char>(params.column_separator));
+ _value_separator_length = 1;
+ }
+ if (params.__isset.line_delimiter_length && params.line_delimiter_length > 1) {
+ _line_delimiter = params.line_delimiter_str;
+ _line_delimiter_length = params.line_delimiter_length;
+ } else {
+ _line_delimiter.push_back(static_cast<char>(params.line_delimiter));
+ _line_delimiter_length = 1;
Review comment:
`_line_delimiter_length` seams useless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org