You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/04 20:22:21 UTC
[GitHub] [flink] tweise commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
tweise commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374902191
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
Review comment:
Looks like there is consensus to keep it centralized; I prefer that as well. This dependency isn't specific to Kinesis, it comes from `aws-java-sdk-core`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services