You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/10/29 18:32:51 UTC
[GitHub] [datasketches-cpp] will-lauer opened a new pull request #249: Restructuring theta so that wrapped compact has standard methods
will-lauer opened a new pull request #249:
URL: https://github.com/apache/datasketches-cpp/pull/249
Introducing a base_theta_sketch_alloc as a base class and moving most
methods to that class, except for iterators, so that
wrapped_compact_theta_sketch can inherit from the same base class as the
rest of the sketch methods, and thus have the same API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #249: Restructuring theta so that wrapped compact has standard methods
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #249:
URL: https://github.com/apache/datasketches-cpp/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #249: Restructuring theta so that wrapped compact has standard methods
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #249:
URL: https://github.com/apache/datasketches-cpp/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #249: Restructuring theta so that wrapped compact has standard methods
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #249:
URL: https://github.com/apache/datasketches-cpp/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #249: Restructuring theta so that wrapped compact has standard methods
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #249:
URL: https://github.com/apache/datasketches-cpp/pull/249#issuecomment-954968878
## Pull Request Test Coverage Report for [Build 1400166963](https://coveralls.io/builds/43882244)
* **7** of **19** **(36.84%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.1%**) to **92.635%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/43882244/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L61) | 5 | 17 | 29.41%
<!-- | **Total:** | **7** | **19** | **36.84%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/43882244/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L91) | 1 | 14.96% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/43882244) |
| :-- | --: |
| Change from base [Build 1396585990](https://coveralls.io/builds/43858158): | -0.1% |
| Covered Lines: | 2176 |
| Relevant Lines: | 2349 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org