You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/02/03 19:59:57 UTC
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-lib/pull/376
CB-10461: 'cordova platform ls' should list the versions of platforms pinned
Added version information to available platforms list. The output will
be similar to:
E:\projects\MyApp3> cordova platform ls
Installed platforms: android 5.0.0, blackberry10 3.8.0-dev, browser
4.0.0, firefoxos 3.6.3, windows 4.2.0, wp8 (deprecated)
Available platforms: amazon-fireos ~3.6.3 (deprecated), webos ~3.7.0,
windows8 ~4.2.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-lib CB-10461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #376
----
commit 6fc3360a905a5c72612648ff83263e81faa8e31e
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-02-03T18:58:00Z
CB-10461: 'cordova platform ls' should list the versions of platforms pinned
Added version information to available platforms list. The output will
be similar to:
E:\projects\MyApp3> cordova platform ls
Installed platforms: android 5.0.0, blackberry10 3.8.0-dev, browser
4.0.0, firefoxos 3.6.3, windows 4.2.0, wp8 (deprecated)
Available platforms: amazon-fireos ~3.6.3 (deprecated), webos ~3.7.0,
windows8 ~4.2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179503770
Yeah, and in fact, for consistency maybe "installed platforms" should also be separated by line breaks rather than commas:
```
Installed platforms:
android 5.1.0
browser 4.1.0-dev
Available platforms:
amazon-fireos ~3.6.3 (deprecated)
blackberry10 ~3.8.0
firefoxos ~3.6.3
webos ~3.7.0
windows ~4.3.0
windows8 ~4.3.0
wp8 ~3.8.2 (deprecated)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179498720
I like the idea, but find the list is starting to get a bit confusing (to see the actual platform names. We need to make sure the platform names a very easy to see. On option that might help would be to switch to using line breaks instead of commas, something like:
```
Installed platforms: browser 4.1.0-dev
Available platforms:
amazon-fireos ~3.6.3 (deprecated)
android ~5.1.0
blackberry10 ~3.8.0
firefoxos ~3.6.3
webos ~3.7.0
windows ~4.3.0
windows8 ~4.3.0
wp8 ~3.8.2 (deprecated)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179500082
That's more like what we do for plugins (`cordova plugin ls`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179511413
Looks great! Just one comment: I think just a couple of spaces would look better than a tab.
Also, looks like there is a test that is sensitive to the output of this command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179407654
@dblotsky @nikhilkh @riknoll, @vladimir-kotikov Can you please review and merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179505519
@TimBarham @nikhilkh Agreed. Added formatting changes. Now the display will be like:
Installed platforms:
android 5.0.0
blackberry10 3.8.0-dev
browser 4.0.0
firefoxos 3.6.3
windows 4.2.0
wp8 (deprecated)
Available platforms:
amazon-fireos ~3.6.3 (deprecated)
webos ~3.7.0
windows8 ~4.2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org