You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "akronenw (via GitHub)" <gi...@apache.org> on 2023/02/18 13:25:35 UTC
[GitHub] [netbeans] akronenw opened a new pull request, #5533: Add port offset to wildfly server wizard
akronenw opened a new pull request, #5533:
URL: https://github.com/apache/netbeans/pull/5533
This is a replacement for #5478.
Instead of parsing the default port offset from the configuration file, it is now possible to set the offset in the Wildfly server creation wizard. The offset is then passed to Wildfly via `-Djboss.socket.binding.port-offset`. That approach is more transparent to the user and NetBeans keeps track of the correct ports used. I tested this successfully.
Anyway, I made this a draft because of a bunch of questions I have, where I hope @ehsavoie (and/or others) can help me out:
1. Should we validate that port + port offset is in the valid port range? Or just let Wildfly fail and report that?
2. Does it make sense to add a tooltip to the port offset label and explain what is going on?
3. I don't understand exactly how my changes will affect the connection to an already running server. I guess the port offset should be ignored then?
4. The ports are queried from the `InstanceProperties` in various places, maybe they should be regular class members? There is a lot of overhead at the moment for adding offset, parsing to int and to string.
Looking forward to getting input on these points!
Alex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5533: Add port offset to wildfly server wizard
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5533:
URL: https://github.com/apache/netbeans/pull/5533#issuecomment-1542161173
closing in favor of #5597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien closed pull request #5533: Add port offset to wildfly server wizard
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien closed pull request #5533: Add port offset to wildfly server wizard
URL: https://github.com/apache/netbeans/pull/5533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists