[GitHub] [accumulo] foster33 commented on a change in pull request #2397: Add consistency checks for lastFlushID and lastCompactID

[GitBox <gi...@apache.org>]

foster33 commented on a change in pull request #2397:
URL: https://github.com/apache/accumulo/pull/2397#discussion_r778889049



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -1412,12 +1412,40 @@ private void closeConsistencyCheck() {
 
     if (!otherLogs.isEmpty() || !currentLogs.isEmpty() || !referencedLogs.isEmpty()) {
       String msg = "Closed tablet " + extent + " has walog entries in memory currentLogs = "
-          + currentLogs + "  otherLogs = " + otherLogs + " refererncedLogs = " + referencedLogs;
+          + currentLogs + "  otherLogs = " + otherLogs + " referencedLogs = " + referencedLogs;
       log.error(msg);
       throw new RuntimeException(msg);
     }
 
-    // TODO check lastFlushID and lostCompactID - ACCUMULO-1290
+    // If a table hasn't been flushed before it was closed then lastFlushID will be -1 while
+    // getFlushID will be 0.
+    try {
+      long flushID = getFlushID();

Review comment:
       So I was looking into this and I have some questions.
   
   You mentioned that we can change the Ample code that reads the tablet metadata to include flushID and do what you had suggested. I was curious what part of code that may be. I could not identify it, but I did see that Ample already had knowledge of flushID in general. 
   
   Would the change just deal with how the variable is updated? Or would it be dealing with something more complex?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org