You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/21 01:25:34 UTC

[GitHub] [rocketmq-client-go] DandelionJR opened a new issue #471: golang客户端消费者订阅时写的模式和页面客户端上显示的不一致

DandelionJR opened a new issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471


   我在测试rocketmq时，消费者订阅采用的是BROADCASTING，页面上却显示为CLUSTERING。我在源码中仔细查找，发现写死CLUSTERING，如下所示：
   c.consumerMap.Range(func(key, value interface{}) bool { consumer := value.(InnerConsumer) cData := consumerData{ GroupName: key.(string), CType: "PUSH", MessageModel: "CLUSTERING", Where: "CONSUME_FROM_FIRST_OFFSET", UnitMode: consumer.IsUnitMode(), SubscriptionDatas: consumer.SubscriptionDataList(), } hbData.ConsumerDatas.Add(cData) return true })
   这段代码在internal.client.go的SendHeartbeatToAllBrokerWithLock中，当我改变MessageModel的值为BROADCASTING时，页面上显示为BROADCASTING，请问这是bug还是我自己测试错误


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] DandelionJR commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
DandelionJR commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-616948748


   I have solved this problem, you can review it, thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-616905617


   yes, It is a bug. the message mode should be getting from the inner client and set here in the heartbeat data. then it will be sent to the broker.
   Could you pls create a PR to fix it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-617522336


   GJ, I find that you create a PR on the release 2.0.0 branch, could you please move this PR to the native branch?
   we should not modify the branch which has been released.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-616913074


   Maybe you can refer to the implementation logic of IsUnitMode().


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] DandelionJR commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
DandelionJR commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-616908248


   Ok, I'm looking at the interface method of the inner client. I haven't found where the model is, but I can clearly find it from the debug. I want to study it furtherly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] DandelionJR commented on issue #471: The message mode was wrong in the heartbeat data.

Posted by GitBox <gi...@apache.org>.
DandelionJR commented on issue #471:
URL: https://github.com/apache/rocketmq-client-go/issues/471#issuecomment-616915064


   Thanks, i know how to solve it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org