You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/06/10 14:34:05 UTC

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control CookieManager.java

sebb        2004/06/10 05:34:05

  Modified:    src/protocol/http/org/apache/jmeter/protocol/http/control
                        Tag: rel-2_0 CookieManager.java
  Log:
  Bugzilla 29493 - Cookie Manager doesn't remove expired cookies
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.26.2.1  +4 -8      jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
  
  Index: CookieManager.java
  ===================================================================
  RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java,v
  retrieving revision 1.26
  retrieving revision 1.26.2.1
  diff -u -r1.26 -r1.26.2.1
  --- CookieManager.java	23 Mar 2004 23:23:32 -0000	1.26
  +++ CookieManager.java	10 Jun 2004 12:34:05 -0000	1.26.2.1
  @@ -359,12 +359,8 @@
                   {
                       String expires = nvp.substring(index + 1);
                       Date date = dateFormat.parse(expires);
  -                    if (date.getTime() > System.currentTimeMillis())
  -                        //TODO: why this conditional? If it's expired, it's
  -                        // expired!
  -                    {
  -                        newCookie.setExpires(date.getTime());
  -                    }
  +                    //Always set expiry date - see Bugzilla id 29493
  +                    newCookie.setExpires(date.getTime());
                   }
                   catch (ParseException pe)
                   {
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org