You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jm...@apache.org on 2017/12/28 00:47:43 UTC
[incubator-plc4x] 05/19: remove unneeded asserts
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit 43e871c235faafd62536c06056966e03fd2cbc7a
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Thu Dec 28 08:04:43 2017 +1100
remove unneeded asserts
---
.../apache/plc4x/java/isotp/netty/model/types/IsotpTypeTests.java | 7 -------
1 file changed, 7 deletions(-)
diff --git a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/types/IsotpTypeTests.java b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/types/IsotpTypeTests.java
index cd55011..8a91e01 100644
--- a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/types/IsotpTypeTests.java
+++ b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/types/IsotpTypeTests.java
@@ -32,15 +32,12 @@ class IsotpTypeTests {
DeviceGroup deviceGroup;
deviceGroup = DeviceGroup.PG_OR_PC;
- assertTrue(deviceGroup == DeviceGroup.PG_OR_PC, "1 incorrectly mapped");
assertTrue(deviceGroup.getCode() == (byte)1, "code is not 1");
deviceGroup = DeviceGroup.OS;
- assertTrue(deviceGroup == DeviceGroup.OS, "2 incorrectly mapped");
assertTrue(deviceGroup.getCode() == (byte)2, "code is not 2");
deviceGroup = DeviceGroup.OTHERS;
- assertTrue(deviceGroup == DeviceGroup.OTHERS, "3 incorrectly mapped");
assertTrue(deviceGroup.getCode() == (byte)3, "code is not 3");
}
@@ -93,19 +90,15 @@ class IsotpTypeTests {
ProtocolClass protocolClass;
protocolClass = ProtocolClass.CLASS_1;
- assertTrue(protocolClass == ProtocolClass.CLASS_1, "0x10 incorrectly mapped");
assertTrue(protocolClass.getCode() == (byte)0x10, "code is not 0x10");
protocolClass = ProtocolClass.CLASS_2;
- assertTrue(protocolClass == ProtocolClass.CLASS_2, "0x20 incorrectly mapped");
assertTrue(protocolClass.getCode() == (byte)0x20, "code is not 0x20");
protocolClass = ProtocolClass.CLASS_3;
- assertTrue(protocolClass == ProtocolClass.CLASS_3, "0x30 incorrectly mapped");
assertTrue(protocolClass.getCode() == (byte)0x30, "code is not 0x30");
protocolClass = ProtocolClass.CLASS_4;
- assertTrue(protocolClass == ProtocolClass.CLASS_4, "0x40 incorrectly mapped");
assertTrue(protocolClass.getCode() == (byte)0x40, "code is not 0x40");
}
--
To stop receiving notification emails like this one, please contact
"commits@plc4x.apache.org" <co...@plc4x.apache.org>.