You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemds.apache.org by ba...@apache.org on 2025/02/03 15:25:25 UTC
(systemds) branch main updated: [MINOR] Fix CompressionSettings static boolean
This is an automated email from the ASF dual-hosted git repository.
baunsgaard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/main by this push:
new ece172ae73 [MINOR] Fix CompressionSettings static boolean
ece172ae73 is described below
commit ece172ae730a2d9de4c3faffc3aa231468e7d466
Author: Sebastian Baunsgaard <ba...@apache.org>
AuthorDate: Mon Feb 3 16:24:59 2025 +0100
[MINOR] Fix CompressionSettings static boolean
---
.../sysds/runtime/compress/CompressionSettings.java | 3 ++-
.../test/component/compress/CompressedLoggingTests.java | 16 ++++++++++++++++
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/sysds/runtime/compress/CompressionSettings.java b/src/main/java/org/apache/sysds/runtime/compress/CompressionSettings.java
index 4038163db9..31c034ef4d 100644
--- a/src/main/java/org/apache/sysds/runtime/compress/CompressionSettings.java
+++ b/src/main/java/org/apache/sysds/runtime/compress/CompressionSettings.java
@@ -128,7 +128,8 @@ public class CompressionSettings {
/** The sorting type used in sorting/joining offsets to create SDC groups */
public final SORT_TYPE sdcSortType;
- private static boolean printedStatus = false;
+ /** if the settings have been logged already. */
+ public static boolean printedStatus = false;
protected CompressionSettings(double samplingRatio, double samplePower, boolean allowSharedDictionary,
String transposeInput, int seed, boolean lossy, EnumSet<CompressionType> validCompressions,
diff --git a/src/test/java/org/apache/sysds/test/component/compress/CompressedLoggingTests.java b/src/test/java/org/apache/sysds/test/component/compress/CompressedLoggingTests.java
index dd4707a72c..37d5644443 100644
--- a/src/test/java/org/apache/sysds/test/component/compress/CompressedLoggingTests.java
+++ b/src/test/java/org/apache/sysds/test/component/compress/CompressedLoggingTests.java
@@ -47,6 +47,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.TRACE);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(1000, 5, 1, 1, 0.5, 235);
MatrixBlock m2 = CompressedMatrixBlockFactory.compress(mb).getLeft();
@@ -73,6 +74,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(1000, 5, 1, 1, 0.5, 235);
InstructionTypeCounter inst = new InstructionTypeCounter(10, 0, 0, 0, 0, 0, 0, 0, false);
@@ -101,6 +103,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(2000, 1001, 1, 65, 0.5, 235);
mb = TestUtils.round(mb);
@@ -129,6 +132,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(5, 5, 0.2, 1, 0.5, 235);
@@ -156,6 +160,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10, 50, 1, 1, 0.5, 235);
@@ -183,6 +188,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10, 50, 1, 1, 0.5, 235);
InstructionTypeCounter inst = new InstructionTypeCounter(10, 0, 0, 0, 0, 0, 0, 0, false);
@@ -210,6 +216,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10, 50, 1, 1, 0.5, 235);
InstructionTypeCounter inst = new InstructionTypeCounter(0, 10, 0, 0, 0, 0, 0, 0, true);
@@ -237,6 +244,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(100, 2, 1, 1, 0.5, 235);
CompressionSettingsBuilder sb = new CompressionSettingsBuilder();
@@ -265,6 +273,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.TRACE);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10000, 1, 1, 128, 0.5, 235);
mb = TestUtils.round(mb);
@@ -292,6 +301,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.TRACE);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10, 1000, 1, 1, 1.0, 235);
mb = TestUtils.round(mb);
@@ -319,6 +329,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.TRACE);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(10, 1000, 1, 1, 0.0, 235);
mb = TestUtils.round(mb);
@@ -346,6 +357,7 @@ public class CompressedLoggingTests {
TestAppender appender = null;
try {
+ CompressionSettings.printedStatus = false;
appender = LoggingUtils.overwrite();
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(100, 3, 1, 1, 0.5, 235);
@@ -375,6 +387,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressedMatrixBlockFactory.class).setLevel(Level.DEBUG);
MatrixBlock mb = TestUtils.generateTestMatrixBlock(400, 600, 1, 1024, 0.18, 235);
mb = TestUtils.round(mb);
@@ -406,6 +419,7 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
Logger.getLogger(CompressionSettings.class).setLevel(Level.DEBUG);
new CompressionSettingsBuilder().create();
final List<LoggingEvent> log = LoggingUtils.reinsert(appender);
@@ -430,6 +444,8 @@ public class CompressedLoggingTests {
final TestAppender appender = LoggingUtils.overwrite();
try {
+ CompressionSettings.printedStatus = false;
+
Logger.getLogger(CompressionSettings.class).setLevel(Level.DEBUG);
new CompressionSettingsBuilder().setSamplingRatio(0.1).create();
final List<LoggingEvent> log = LoggingUtils.reinsert(appender);