You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Antonio <an...@vieiro.net> on 2017/10/03 06:57:59 UTC
nbproject/*-impl.xml and genfiles.properties
Hi all,
I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
nbproject/genfiles.properties.
These are automatically generated in the IDE so,
- I'm not adding license headers to these.
- Should I remove them from git?
Thanks,
Antonio
Re: nbproject/*-impl.xml and genfiles.properties
Posted by Antonio <an...@vieiro.net>.
Problems to be solved centrally
build.xml, build-impl.xml, project.properties, genfiles.properties,
D'oh! Sorry
On 03/10/17 08:57, Antonio wrote:
> Hi all,
>
> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
> nbproject/genfiles.properties.
>
> These are automatically generated in the IDE so,
>
> - I'm not adding license headers to these.
> - Should I remove them from git?
>
> Thanks,
> Antonio
Re: Grep CDDL (was Re: PR #46)
Posted by Antonio Vieiro <an...@vieiro.net>.
Aha! I now understand :-)
I’ll doublecheck that the files excluded don’t have any original license headers.
Thanks,
Antonio
> El 3 oct 2017, a las 15:36, Jan Lahoda <la...@gmail.com> escribió:
>
> Sorry, I probably should have been more precise.
>
> All I meant was a check that the files excluded from Rat don't have the
> original license header (as due to the excludes, Rat would no longer report
> them). I tried to check, and it seems that none of the excluded files has
> the headers, so this should be OK.
>
> Thanks,
> Jan
>
>
> On Tue, Oct 3, 2017 at 1:34 PM, Antonio <an...@vieiro.net> wrote:
>
>>
>>
>> On 03/10/17 12:59, Antonio wrote:
>>
>>>
>>> I'll investigate the grep operation on CDDL and will post here with my
>>> findings.
>>>
>>>
>> It seems ant-rat is not able to do this.
>>
>> Anyway one can quickly find CDDL files with
>> grep -R CDDL --exclude-dir build
>>
>> Or adding
>>
>> <target name="grep-cddl" depends="bootstrap">
>> <exec osfamily="unix" executable="grep" failonerror="yes">
>> <arg line="-R CDDL --exclude-dir build" />
>> </exec>
>> </target>
>>
>> to nbbuild/build.xml and then running ant grep-cddl
>>
>> This is Linux specific (and should run in OS/X as well).
>>
>> Want another PR with this?
>>
>> Cheers,
>> Antonio
>>
Re: Grep CDDL (was Re: PR #46)
Posted by Jan Lahoda <la...@gmail.com>.
Sorry, I probably should have been more precise.
All I meant was a check that the files excluded from Rat don't have the
original license header (as due to the excludes, Rat would no longer report
them). I tried to check, and it seems that none of the excluded files has
the headers, so this should be OK.
Thanks,
Jan
On Tue, Oct 3, 2017 at 1:34 PM, Antonio <an...@vieiro.net> wrote:
>
>
> On 03/10/17 12:59, Antonio wrote:
>
>>
>> I'll investigate the grep operation on CDDL and will post here with my
>> findings.
>>
>>
> It seems ant-rat is not able to do this.
>
> Anyway one can quickly find CDDL files with
> grep -R CDDL --exclude-dir build
>
> Or adding
>
> <target name="grep-cddl" depends="bootstrap">
> <exec osfamily="unix" executable="grep" failonerror="yes">
> <arg line="-R CDDL --exclude-dir build" />
> </exec>
> </target>
>
> to nbbuild/build.xml and then running ant grep-cddl
>
> This is Linux specific (and should run in OS/X as well).
>
> Want another PR with this?
>
> Cheers,
> Antonio
>
Re: Grep CDDL (was Re: PR #46)
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hey,
Am Dienstag, den 03.10.2017, 13:34 +0200 schrieb Antonio:
>
> On 03/10/17 12:59, Antonio wrote:
> >
> > I'll investigate the grep operation on CDDL and will post here with
> > my
> > findings.
> >
>
> It seems ant-rat is not able to do this.
>
> Anyway one can quickly find CDDL files with
> grep -R CDDL --exclude-dir build
>
> Or adding
>
> <target name="grep-cddl" depends="bootstrap">
> <exec osfamily="unix" executable="grep" failonerror="yes">
> <arg line="-R CDDL --exclude-dir build" />
> </exec>
> </target>
>
> to nbbuild/build.xml and then running ant grep-cddl
>
> This is Linux specific (and should run in OS/X as well).
>
> Want another PR with this?
I would not add greps for CDDL to the build scripts. Before adding the
excludes I suggest to cleanup the files that would be ignored and make
sure these are clean. Reintroductions via PRs need to be prevented by
the authors/committers.
Greetings
Matthias
Grep CDDL (was Re: PR #46)
Posted by Antonio <an...@vieiro.net>.
On 03/10/17 12:59, Antonio wrote:
>
> I'll investigate the grep operation on CDDL and will post here with my
> findings.
>
It seems ant-rat is not able to do this.
Anyway one can quickly find CDDL files with
grep -R CDDL --exclude-dir build
Or adding
<target name="grep-cddl" depends="bootstrap">
<exec osfamily="unix" executable="grep" failonerror="yes">
<arg line="-R CDDL --exclude-dir build" />
</exec>
</target>
to nbbuild/build.xml and then running ant grep-cddl
This is Linux specific (and should run in OS/X as well).
Want another PR with this?
Cheers,
Antonio
PR #46 (was Re: Want a PR? (was Re: nbproject/*-impl.xml and
genfiles.properties))
Posted by Antonio <an...@vieiro.net>.
On 03/10/17 12:18, Jan Lahoda wrote:
> On Tue, Oct 3, 2017 at 11:51 AM, Antonio <an...@vieiro.net> wrote:
>> I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties'
>> to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test
>> projects as well, and not */nbproject that only affects the module).
>>
>
> I personally would probably be more strict and and exclude specifically
> **/nbproject/build-impl.xml and **/nbproject/jfx-impl.xml. Would it be
> possible to grep the excluded files for word "CDDL", to be sure there's no
> forgotten license header in them? Using ** seems OK to me.
>
See PR #46 https://github.com/apache/incubator-netbeans/pull/46
with the new patterns for exclusion.
I'll investigate the grep operation on CDDL and will post here with my
findings.
Cheers,
Antonio
Re: Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties)
Posted by Jan Lahoda <la...@gmail.com>.
On Tue, Oct 3, 2017 at 11:51 AM, Antonio <an...@vieiro.net> wrote:
> On 03/10/17 11:09, Jaroslav Tulach wrote:
>
>> Hello Antonio,
>> thanks for your help.
>>
>
> My pleasure.
>
> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
>>> nbproject/genfiles.properties.
>>>
>>> These are automatically generated in the IDE so,
>>>
>>> - Should I remove them from git?
>>>
>>
>> No, add them to the rat tool exclude list.
>>
>
> Done.
>
> I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties'
> to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test
> projects as well, and not */nbproject that only affects the module).
>
I personally would probably be more strict and and exclude specifically
**/nbproject/build-impl.xml and **/nbproject/jfx-impl.xml. Would it be
possible to grep the excluded files for word "CDDL", to be sure there's no
forgotten license header in them? Using ** seems OK to me.
>
> Shall I submit a pull request with these?
>
Yes please. Thanks for your help,
Jan
>
>
>> Problems to be solved centrally
>>> build.xml, build-impl.xml, project.properties, genfiles.properties,
>>>
>>
>> I would suggest to add licenses to build.xml and project.properties - e.g.
>> those that aren't generated.
>>
>
> Of course.
>
Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties)
Posted by Antonio <an...@vieiro.net>.
On 03/10/17 11:09, Jaroslav Tulach wrote:
> Hello Antonio,
> thanks for your help.
My pleasure.
>> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
>> nbproject/genfiles.properties.
>>
>> These are automatically generated in the IDE so,
>>
>> - Should I remove them from git?
>
> No, add them to the rat tool exclude list.
Done.
I've added '**/nbproject/*-impl.xml' and
'**/nbproject/genfiles.properties' to the rat exclusion list. (Note:
**/nbproject/, so that affects qa-test projects as well, and not
*/nbproject that only affects the module).
Shall I submit a pull request with these?
>
>> Problems to be solved centrally
>> build.xml, build-impl.xml, project.properties, genfiles.properties,
>
> I would suggest to add licenses to build.xml and project.properties - e.g.
> those that aren't generated.
Of course.
Re: nbproject/*-impl.xml and genfiles.properties
Posted by Jaroslav Tulach <ja...@oracle.com>.
Hello Antonio,
thanks for your help.
On úterý 3. října 2017 8:57:59 CEST Antonio wrote:
> Hi all,
>
> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
> nbproject/genfiles.properties.
>
> These are automatically generated in the IDE so,
>
> - I'm not adding license headers to these.
Correct, imho.
> - Should I remove them from git?
No, add them to the rat tool exclude list.
>Problems to be solved centrally
> build.xml, build-impl.xml, project.properties, genfiles.properties,
I would suggest to add licenses to build.xml and project.properties - e.g.
those that aren't generated.
-jt