[GitHub] [hive] nrg4878 commented on a change in pull request #2385: HIVE-25238: Make SSL cipher suites configurable for Hive Web UI and HS2

[GitBox <gi...@apache.org>]

nrg4878 commented on a change in pull request #2385:
URL: https://github.com/apache/hive/pull/2385#discussion_r651424467



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4183,9 +4186,14 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
     HIVE_SERVER2_SSL_KEYSTORE_PASSWORD("hive.server2.keystore.password", "",
         "SSL certificate keystore password."),
     HIVE_SERVER2_SSL_KEYSTORE_TYPE("hive.server2.keystore.type", "",
-            "SSL certificate keystore type."),
+        "SSL certificate keystore type."),
     HIVE_SERVER2_SSL_KEYMANAGERFACTORY_ALGORITHM("hive.server2.keymanagerfactory.algorithm", "",
-            "SSL certificate keystore algorithm."),
+        "SSL certificate keystore algorithm."),
+    HIVE_SERVER2_SSL_HTTP_EXCLUDE_CIPHERSUITES("hive.server2.http.exclude.ciphersuites", "",

Review comment:
       Do we really need 3 separate configuration params for this? Can and should the same value be used for both http and binary transports and webui as well? is there ever a case, where the value of each differs from each other? 

##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java
##########
@@ -24,10 +24,13 @@
 import java.util.concurrent.SynchronousQueue;
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
+import java.util.Set;
 
 import javax.net.ssl.KeyManagerFactory;
 import javax.ws.rs.HttpMethod;
 
+import com.google.common.base.Splitter;

Review comment:
       Does this import add new compile time dependencies for HS2 service module? I am just trying to make sure that this binary is already being used else where in this code, so we are not adding a new runtime dependency for this code. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org