Re: [PR] test: visual test support compare with a PR id [echarts]

["100pah (via GitHub)" <gi...@apache.org>]

100pah commented on code in PR #20676:
URL: https://github.com/apache/echarts/pull/20676#discussion_r2021361167


##########
test/runTest/cli.js:
##########
@@ -78,12 +80,12 @@ function getClientRelativePath(absPath) {
     return path.join('../', path.relative(__dirname, absPath));
 }
 
-function replaceEChartsVersion(interceptedRequest, version) {
+function replaceEChartsVersion(interceptedRequest, source, version) {
     // TODO Extensions and maps
     if (interceptedRequest.url().endsWith('dist/echarts.js')) {
-        console.log('Use echarts version: ' + version);
+        console.log('Use echarts version: ' + source + ' ' + version);
         interceptedRequest.continue({

Review Comment:
   After this modification, the feature of "replay in record" is broken.
   
   <img width="1470" alt="image" src="https://github.com/user-attachments/assets/5c83c9cb-21c2-4beb-b153-2b0968f0480f" />
   
   This is due to the missing modification of:
   ```js
       else {
           // Only run once
           await runTestPage(browser, testOpt, 'local', runtimeCode, true);
       }
   ```
   That is, not all call of `runTestPage` are modified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org