You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/09 03:25:28 UTC

[GitHub] [helix] zhangmeng916 commented on a change in pull request #1451: testUpdateConfigFields failure

zhangmeng916 commented on a change in pull request #1451:
URL: https://github.com/apache/helix/pull/1451#discussion_r502163980



##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -243,6 +243,7 @@ public void testAddConfigFields() throws IOException {
     oldConfig.getRecord().update(configDelta.getRecord());
     Assert.assertEquals(newConfig, oldConfig,
         "cluster config from response: " + newConfig + " vs cluster config actually: " + oldConfig);
+    System.out.println("new config:" + newConfig.toString());

Review comment:
       Is this PR for review? Looks like it's only for debugging purpose instead of fixing the test failure. @kaisun2000 Maybe you can mark it as WIP if it's only for testing. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org