[GitHub] [pinot] Jackie-Jiang commented on pull request #10904: Refactored broker start to allow registration of filter in BrokerAdminApiApplication

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #10904:
URL: https://github.com/apache/pinot/pull/10904#issuecomment-1595499931

   `init()` should not connect the component to the cluster.
   To allow registering extra properties, we can add a method in `BaseBrokerStarter()` and leave the default implementation empty. The sub-class can override the new method. Something like:
   ```
       _brokerAdminApplication =
           new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf,
               _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory);
       registerExtraComponents(_brokerAdminApplication);
       _brokerAdminApplication.start(_listenerConfigs);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org