You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/08/29 09:25:37 UTC

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2969: feat(bindings/nodejs): Implement presign test

Xuanwo commented on code in PR #2969:
URL: https://github.com/apache/incubator-opendal/pull/2969#discussion_r1308481046


##########
bindings/nodejs/tests/binding.js:
##########
@@ -75,6 +75,12 @@ Then('The async file {string} must have content {string}', async function (path,
   assert(bs.toString() == content)
 })
 
-Then('The presign operation should success or raise exception Unsupported', function () {
-  // TODO: please implement me.
+Then('The presign operation should success or raise exception Unsupported', async function () {
+  try {
+    await this.op.presignStat('path', 1000)
+    await this.op.presignRead('path', 1000)
+    await this.op.presignWrite('path', 1000)
+  } catch (e) {
+    assert.ok(e.message.includes('Unsupported'))

Review Comment:
   Seems not a good design, I expect users can check `e.kind()`. There is nothing we can do about this. Let's keep as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org