You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/07/19 19:32:19 UTC
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh opened a new pull request #15: SLING-10642 update unittests
joerghoh opened a new pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh merged pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
joerghoh merged pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh merged pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
joerghoh merged pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#discussion_r672872628
##########
File path: pom.xml
##########
@@ -260,6 +260,12 @@
<version>1.4</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
This dependency is already declared in line 246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#discussion_r672872628
##########
File path: pom.xml
##########
@@ -260,6 +260,12 @@
<version>1.4</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
This dependency is already declared in line 246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
joerghoh commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883261963
I merged da4e5c044a25b5bf2c48cb666f1d2f7d6faa1e1a, thanks for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#discussion_r672872628
##########
File path: pom.xml
##########
@@ -260,6 +260,12 @@
<version>1.4</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
This dependency is already declared in line 246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883177770
I added one more commit in https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/da4e5c044a25b5bf2c48cb666f1d2f7d6faa1e1a to get rid of commons.testing. Feel free to cherry pick to your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
joerghoh commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883261963
I merged da4e5c044a25b5bf2c48cb666f1d2f7d6faa1e1a, thanks for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883152976
Shouldn't we try to remove usage of commons-testing alltogether? The only remaining usages are in `JcrNodeResourceIteratorTest` leveraging `MockNode` and `MockNodeIterator` which should be replaced by https://sling.apache.org/documentation/development/jcr-mock.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883152976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #15: SLING-10642 update unittests
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/15#issuecomment-883152976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org