You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Wetterquarz (via GitHub)" <gi...@apache.org> on 2023/05/02 09:05:19 UTC

[GitHub] [echarts] Wetterquarz opened a new issue, #18583: [Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces

Wetterquarz opened a new issue, #18583:
URL: https://github.com/apache/echarts/issues/18583

   ### Version
   
   5.4.2
   
   ### Link to Minimal Reproduction
   
   https://echarts.apache.org/examples/en/editor.html?c=line-marker&code=PYBwLglsB2AEC8sDeAoWtJgDYFMBcya6GOAHmAQOQAqOAtiDgE4CGYArkzrAMIAWLaAHNuEOGD7cewOmKGwA6jhwBrADSxBAE02wsMeWDJgMkriwBmRphmCwLwJgGNuAd1YgQc27AGeccK4QEpqAPBuAhjsRUZEx0ZRqROhG5ADKYACeuASoxMTAAG7MFvquVABG5irxicRBWhIEACwADABMNQC-RB0JHQDcQA
   
   ### Steps to Reproduce
   
   1. Create a chart with any text and set it up to wrap set text when overflowing.
   2. Use characters of the so-called non-BMP.
   3. Try some widths until you break within the character or before a space (or both as in the minimal reproduction)
   
   ### Current Behavior
   
   ![image](https://user-images.githubusercontent.com/24505746/235624311-a81becd3-7845-4a3e-800d-457307fedc8d.png)
   The 3rd line starts with a space.
   The 3rd line doesn't calculate the character widths correctly and is short.
   One of the Domino Tiles has been broken into two illegal characters.
   
   ### Expected Behavior
   
   According to the Unicode Standard  (https://www.unicode.org/reports/tr14/#SP) the wrapping should occur after all space-characters when a line-break is desired by the algorithm. Characters should also, obviously, not be broken in two and their width should be correctly determined.
   
   ### Environment
   
   ```markdown
   - OS: Windows 10
   - Browser: Edge 112.0.1722.58 (Chromium)
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Wetterquarz commented on issue #18583: [Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces

Posted by "Wetterquarz (via GitHub)" <gi...@apache.org>.
Wetterquarz commented on issue #18583:
URL: https://github.com/apache/echarts/issues/18583#issuecomment-1647766088

   There already is a pull request pending (https://github.com/ecomfe/zrender/pull/1006)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on issue #18583: [Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces

Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on issue #18583:
URL: https://github.com/apache/echarts/issues/18583#issuecomment-1589045862

   The related logic is at https://github.com/ecomfe/zrender/blob/1e27245f74781ec9e9e6f17650b1caeaee15639e/src/graphic/helper/parseText.ts#L614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #18583: [Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on issue #18583:
URL: https://github.com/apache/echarts/issues/18583#issuecomment-1589046209

   This issue is labeled with `difficulty: easy`.
   @Wetterquarz Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.
   
   Please have a look at [How to debug ECharts](https://github.com/apache/echarts/blob/master/CONTRIBUTING.md#how-to-debug-echarts) if you'd like to give a try. 🤓


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org