[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool
URL: https://github.com/apache/incubator-livy/pull/135#discussion_r266035500
 
 

 ##########
 File path: core/src/main/scala/org/apache/livy/sessions/Kind.scala
 ##########
 @@ -35,6 +35,8 @@ object Shared extends Kind("shared")
 
 object SQL extends Kind("sql")
 
+object ConcurrentSQL extends Kind("concurrentSQL")
 
 Review comment:
   I don't think that it is a good idea to add a new session kind. I think we should rather have a configuration for enabling FAIR vs FIFO and I am wondering if this shouldn't be done cross kind, ie. for all the kinds: why was it done only for SQL?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services