You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by st...@apache.org on 2003/11/20 21:12:13 UTC
cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
stoddard 2003/11/20 12:12:13
Modified: docs/manual/mod mpm_common.xml mpm_winnt.xml
Log:
Win32: MaxMemFree works with mpm_winnt
Revision Changes Path
1.32 +1 -1 httpd-2.0/docs/manual/mod/mpm_common.xml
Index: mpm_common.xml
===================================================================
RCS file: /home/cvs/httpd-2.0/docs/manual/mod/mpm_common.xml,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- mpm_common.xml 25 Jun 2003 20:58:40 -0000 1.31
+++ mpm_common.xml 20 Nov 2003 20:12:13 -0000 1.32
@@ -377,7 +377,7 @@
<contextlist><context>server config</context></contextlist>
<modulelist><module>beos</module><module>leader</module>
<module>mpm_netware</module><module>prefork</module>
-<module>threadpool</module><module>worker</module></modulelist>
+<module>threadpool</module><module>worker</module><module>mpm_winnt</module></modulelist>
<usage>
<p>The <directive>MaxMemFree</directive> directive sets the
1.7 +2 -0 httpd-2.0/docs/manual/mod/mpm_winnt.xml
Index: mpm_winnt.xml
===================================================================
RCS file: /home/cvs/httpd-2.0/docs/manual/mod/mpm_winnt.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- mpm_winnt.xml 11 Apr 2003 01:25:53 -0000 1.6
+++ mpm_winnt.xml 20 Nov 2003 20:12:13 -0000 1.7
@@ -27,6 +27,8 @@
</directivesynopsis>
<directivesynopsis location="mpm_common"><name>MaxRequestsPerChild</name>
</directivesynopsis>
+<directivesynopsis location="mpm_common"><name>MaxMemFree</name>
+</directivesynopsis>
<directivesynopsis location="mpm_common"><name>ScoreBoardFile</name>
</directivesynopsis>
<directivesynopsis location="mpm_common"><name>SendBufferSize</name>
Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
Posted by Yoshiki Hayashi <yo...@xemacs.org>.
Cliff Woolley <jw...@virginia.edu> writes:
>> > One thing that puzzled me while checking the code is that
>> > mpm_winnt.c doesn't call apr_allocator_max_free_set like any
>> > other MPMs (except perchild). Doesn't it have to call it,
>> > too?
>>
>> Yes. I guess I should go back and review FB's change...
>
> Oh, actually, he does appear to have added that in the commit log dated
> stoddard 2003/11/20 11:44:19. I'm still reviewing though.
Oh, my bad. I grepped 2.0 source tree and checked mpm_winnt.c
against HEAD but didn't grep 2.1 tree...
So the change is only in 2.1 and documentation is correct.
--
Yoshiki Hayashi
Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
Posted by Cliff Woolley <jw...@virginia.edu>.
On Wed, 3 Dec 2003, Cliff Woolley wrote:
> On Tue, 2 Dec 2003, Yoshiki Hayashi wrote:
>
> > One thing that puzzled me while checking the code is that
> > mpm_winnt.c doesn't call apr_allocator_max_free_set like any
> > other MPMs (except perchild). Doesn't it have to call it,
> > too?
>
> Yes. I guess I should go back and review FB's change...
Oh, actually, he does appear to have added that in the commit log dated
stoddard 2003/11/20 11:44:19. I'm still reviewing though.
Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
Posted by Cliff Woolley <jw...@virginia.edu>.
On Tue, 2 Dec 2003, Yoshiki Hayashi wrote:
> One thing that puzzled me while checking the code is that
> mpm_winnt.c doesn't call apr_allocator_max_free_set like any
> other MPMs (except perchild). Doesn't it have to call it,
> too?
Yes. I guess I should go back and review FB's change...
--Cliff
Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
Posted by Yoshiki Hayashi <yo...@xemacs.org>.
stoddard@apache.org writes:
> stoddard 2003/11/20 12:12:13
>
> Modified: docs/manual/mod mpm_common.xml mpm_winnt.xml
> Log:
> Win32: MaxMemFree works with mpm_winnt
I noticed this change while I was trying to backport
Japanese translation of 2.1 document to 2.0. Since this
change is only done in 2.1, I dived into source code whether
this applies to 2.0 or not.
AP_INIT_TAKE1("MaxMemFree" in core.c is same and
ap_mpm_set_max_mem_free in mpm_common.c is also same. And
mpm_winnt.c is same, so MaxMemFree should also work on Win32
in 2.0, right?
One thing that puzzled me while checking the code is that
mpm_winnt.c doesn't call apr_allocator_max_free_set like any
other MPMs (except perchild). Doesn't it have to call it,
too?
--
Yoshiki Hayashi
Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml
Posted by Yoshiki Hayashi <yo...@xemacs.org>.
stoddard@apache.org writes:
> stoddard 2003/11/20 12:12:13
>
> Modified: docs/manual/mod mpm_common.xml mpm_winnt.xml
> Log:
> Win32: MaxMemFree works with mpm_winnt
I noticed this change while I was trying to backport
Japanese translation of 2.1 document to 2.0. Since this
change is only done in 2.1, I dived into source code whether
this applies to 2.0 or not.
AP_INIT_TAKE1("MaxMemFree" in core.c is same and
ap_mpm_set_max_mem_free in mpm_common.c is also same. And
mpm_winnt.c is same, so MaxMemFree should also work on Win32
in 2.0, right?
One thing that puzzled me while checking the code is that
mpm_winnt.c doesn't call apr_allocator_max_free_set like any
other MPMs (except perchild). Doesn't it have to call it,
too?
--
Yoshiki Hayashi