[GitHub] reddycharan commented on a change in pull request #1543: Issue 1540: Bookie/BookieServer components shutdown will fail to end exit the BookieProcess

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1543: Issue 1540: Bookie/BookieServer components shutdown will fail to end exit the BookieProcess
URL: https://github.com/apache/bookkeeper/pull/1543#discussion_r202842100
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
 ##########
 @@ -248,11 +267,13 @@ public void run() {
                     Thread.currentThread().interrupt();
                 }
                 if (!isBookieRunning()) {
-                    shutdown();
-                    break;
+                    LOG.info("BookieDeathWatcher noticed the bookie is not running any more, exiting the watch loop!");
 
 Review comment:
   just want to make sure that removal of "shutdown()" call here is intentional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services