You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Daniel Kaplan (JIRA)" <ji...@apache.org> on 2008/02/05 08:05:07 UTC
[jira] Created: (WICKET-1322) NormalUrlCodingStrategy: It does not
append / to the end of the url before the parameters
NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
-----------------------------------------------------------------------------------------
Key: WICKET-1322
URL: https://issues.apache.org/jira/browse/WICKET-1322
Project: Wicket
Issue Type: New Feature
Components: wicket
Affects Versions: 1.3.0-final
Reporter: Daniel Kaplan
For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1322) NormalUrlCodingStrategy: It does
not append / to the end of the url before the parameters
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587430#action_12587430 ]
Matej Knopp commented on WICKET-1322:
-------------------------------------
No objections.
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Matej Knopp
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1322) NormalUrlCodingStrategy: It does not
append / to the end of the url before the parameters
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1322.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.4
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1322) NormalUrlCodingStrategy: It does not
append / to the end of the url before the parameters
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-1322:
---------------------------------------
Assignee: Matej Knopp
matej, are there any objections for removing the last / from that url?
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Matej Knopp
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1322) NormalUrlCodingStrategy: It does
not append / to the end of the url before the parameters
Posted by "Andrew Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594026#action_12594026 ]
Andrew Lombardi commented on WICKET-1322:
-----------------------------------------
What's the latest on this? I'm in favor of fixing the existing one, since there doesn't seem to be any reason for having the extra slash. A side note, it seems to really screw up CSS and image resolution in Internet Explorer 6 and 7.
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1322) NormalUrlCodingStrategy: It does not
append / to the end of the url before the parameters
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-1322:
-----------------------------------
Assignee: Johan Compagner (was: Matej Knopp)
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1322) NormalUrlCodingStrategy: It does
not append / to the end of the url before the parameters
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587535#action_12587535 ]
Johan Compagner commented on WICKET-1322:
-----------------------------------------
i agree with igor
we shouldn't add the NormalUrlCoding to the base but just change QueryString to do what that does
else we clutter the api.
i think that is also what most people want? so any objections to that?
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1322) NormalUrlCodingStrategy: It does
not append / to the end of the url before the parameters
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587455#action_12587455 ]
Igor Vaynberg commented on WICKET-1322:
---------------------------------------
erm, wdym no objections??? why would we have something like this in core when we also have something 99% similar. i find that this one is the one that makes more sense, so why not just change how our default one works?
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1322) NormalUrlCodingStrategy: It does
not append / to the end of the url before the parameters
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594029#action_12594029 ]
Johan Compagner commented on WICKET-1322:
-----------------------------------------
i will try to look at stuff tomorrow,
today i am really already to tired.. :(
been a long long week without almost no sleep for at least 4 nights... got to catch up some first.
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Assignee: Johan Compagner
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1322) NormalUrlCodingStrategy: It does not
append / to the end of the url before the parameters
Posted by "Daniel Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kaplan updated WICKET-1322:
----------------------------------
Attachment: NormalUrlCodingStrategy.java
the file that could be added
> NormalUrlCodingStrategy: It does not append / to the end of the url before the parameters
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-1322
> URL: https://issues.apache.org/jira/browse/WICKET-1322
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Daniel Kaplan
> Attachments: NormalUrlCodingStrategy.java
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For some reason that I cannot understand, QueryStringUrlCodingStrategy will code urls like this:
> www.example.com/a/path/?var=val That last slash is abnormal from what I've seen. I've included a class called NormalUrlCodingStrategy that does the same thing as QueryStringUrlCodingStrategy but does not add this extra slash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.