You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by masaori335 <gi...@git.apache.org> on 2017/02/10 07:33:34 UTC

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

GitHub user masaori335 opened an issue:

    https://github.com/apache/trafficserver/issues/1437

    Build fail with BoringSSL

    I'm trying build TS with BoringSSL, but I got this.
    
    ```
    BIO_fastopen.cc:76:9: error: use of undeclared identifier 'BIO_sock_non_fatal_error'
        if (BIO_sock_non_fatal_error(errno)) {
            ^
    BIO_fastopen.cc:99:9: error: use of undeclared identifier 'BIO_sock_non_fatal_error'
        if (BIO_sock_non_fatal_error(errno)) {
            ^
    2 errors generated.
    ```
    
    BoringSSL doesn't have `BIO_sock_non_fatal_error`. `bio_fd_non_fatal_error` looks similar API, but it is internal API.

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

Posted by jablko <gi...@git.apache.org>.

Github user jablko closed the issue at:

    https://github.com/apache/trafficserver/issues/1437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

Posted by masaori335 <gi...@git.apache.org>.

GitHub user masaori335 reopened an issue:

    https://github.com/apache/trafficserver/issues/1437

    Build fail with BoringSSL

    I'm trying build TS with BoringSSL, but I got this.
    
    ```
    BIO_fastopen.cc:76:9: error: use of undeclared identifier 'BIO_sock_non_fatal_error'
        if (BIO_sock_non_fatal_error(errno)) {
            ^
    BIO_fastopen.cc:99:9: error: use of undeclared identifier 'BIO_sock_non_fatal_error'
        if (BIO_sock_non_fatal_error(errno)) {
            ^
    2 errors generated.
    ```
    
    BoringSSL doesn't have `BIO_sock_non_fatal_error`. `bio_fd_non_fatal_error` looks similar API, but it is internal API.

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

Posted by masaori335 <gi...@git.apache.org>.

Github user masaori335 closed the issue at:

    https://github.com/apache/trafficserver/issues/1437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

Posted by jablko <gi...@git.apache.org>.

Github user jablko commented on the issue:

    https://github.com/apache/trafficserver/issues/1437
  
    Hmm -- I see what you mean -- BoringSSL sock_read() and sock_write() have used bio_fd_non_fatal_error() since [1], which claims to be a fork from https://github.com/openssl/openssl/commit/30ea570f0fb2717b1faca5d611a3ab200c8eac83, however in OpenSSL, they've used BIO_sock_non_fatal_error() since their inception -- and in particular in https://github.com/openssl/openssl/commit/30ea570f0fb2717b1faca5d611a3ab200c8eac83 [2]. I wonder why BoringSSL made this change?
    
    So for fastopen_bread() and fastopen_bwrite(), BIO_sock_non_fatal_error() is correct, and I'm tempted to just copy it from OpenSSL, for implementations that lack it (BoringSSL)?
    
    [1] https://boringssl.googlesource.com/boringssl/+/95c29f3cd1f6c08c6c0927868683392eea727ccb
    [2] https://github.com/openssl/openssl/blob/30ea570f0fb2717b1faca5d611a3ab200c8eac83/crypto/bio/bss_sock.c


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---