You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/20 16:37:46 UTC

[GitHub] [flink-training] NicoK opened a new pull request #2: [FLINK-17276][checkstyle] add definitions from Flink and enforce them

NicoK opened a new pull request #2:
URL: https://github.com/apache/flink-training/pull/2


   This pr is based on #1 and adds Flink's checkstyle configuration plus the appropriate changes to enforce it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-training] alpinegizmo commented on issue #2: [FLINK-17276][checkstyle] add definitions from Flink and enforce them

Posted by GitBox <gi...@apache.org>.

alpinegizmo commented on issue #2:
URL: https://github.com/apache/flink-training/pull/2#issuecomment-617067583


   What a nuisance. Sorry there was so much to clean up. :(  +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-training] tzulitai commented on issue #2: [FLINK-17276][checkstyle] add definitions from Flink and enforce them

Posted by GitBox <gi...@apache.org>.

tzulitai commented on issue #2:
URL: https://github.com/apache/flink-training/pull/2#issuecomment-616942594


   👍  always good to have checkstyle enforced, no objections here as well. LGTM from my side.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org