You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Abhinandan Prateek <ap...@apache.org> on 2013/06/10 08:42:30 UTC
Re: Review Request: Fixed removing secondary ip when no PF rule set
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11343/#review21642
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On May 23, 2013, 11:19 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11343/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 11:19 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and Alena Prokharchyk.
>
>
> Description
> -------
>
> 1. Changed the logic to check the any PF rules exist on the secondary ip
> 2. First getting PF rules for the nic network from the firewall rules.
> 3. Now finding port_forwarding_rules table for firewall rule id and secondary ip address. If query returns empty then no PF rules.
>
> Also reveted getNicInNetwork() method which changed by as part of MIPN feature.
>
>
> This addresses bug CLOUDSTACK-2604.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkModel.java f84a8b0
> engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java 682a941
> engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java cc780cb
> server/src/com/cloud/network/NetworkModelImpl.java 8971f8c
> server/src/com/cloud/network/NetworkServiceImpl.java 1533ca9
> server/src/com/cloud/network/rules/RulesManagerImpl.java 8834553
> server/test/com/cloud/network/MockNetworkModelImpl.java c3a0d6c
> server/test/com/cloud/vpc/MockNetworkModelImpl.java d9e33b7
>
> Diff: https://reviews.apache.org/r/11343/diff/
>
>
> Testing
> -------
>
> 1. Tested on xenserver
> 2. created vm with two nics into networks n1,n2.
> 3. acquired 10.1.1.126 ip to two nics
> 4. added pf rules for n1 network ip
> 5. deleted secondary ip of nic in n2. ip deleted successfully
> 6. Tested add vm nic to network and remove vm nic from network.
>
>
> Thanks,
>
> Jayapal Reddy
>
>