You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/06 07:10:54 UTC

[GitHub] [incubator-kyuubi] simon824 opened a new pull request #1502: [KYUUBI #1501] Introduce operationsResource

simon824 opened a new pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502


   ### _Why are the changes needed?_
   #1501
   Introduce operationsResource
   mv parseSessionHandle() to SessionManager
   mv parseOperationHandle() to OperationManager
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762822168



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -283,4 +286,22 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
       timeoutChecker.scheduleWithFixedDelay(checkTask, interval, interval, TimeUnit.MILLISECONDS)
     }
   }
+
+  def parseSessionHandle(sessionHandleStr: String): SessionHandle = {

Review comment:
       let's move it to `object SessionHandle`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762818997



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/OperationsResource.scala
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.server.api.v1
+
+import javax.ws.rs.{GET, Path, PathParam, Produces, _}
+import javax.ws.rs.core.MediaType
+
+import scala.util.control.NonFatal
+
+import io.swagger.v3.oas.annotations.media.Content
+import io.swagger.v3.oas.annotations.responses.ApiResponse
+import io.swagger.v3.oas.annotations.tags.Tag
+
+import org.apache.kyuubi.server.api.ApiRequestContext
+
+@Tag(name = "Operation")
+@Produces(Array(MediaType.APPLICATION_JSON))
+private[v1] class OperationsResource extends ApiRequestContext {
+
+  @ApiResponse(
+    responseCode = "200",
+    content = Array(new Content(
+      mediaType = MediaType.APPLICATION_JSON)),
+    description =
+      "Get an operation detail with a given session identifier and operation identifier")
+  @GET
+  @Path("{operationHandle}")
+  def getOperationHandle(

Review comment:
       getOperationDetail




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] simon824 commented on pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#issuecomment-986539573


   cc @yanghua @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762821463



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/operation/OperationManager.scala
##########
@@ -137,4 +142,23 @@ abstract class OperationManager(name: String) extends AbstractService(name) {
       }
     }
   }
+
+  def parseOperationHandle(operationHandleStr: String): OperationHandle = {
+    try {
+      val operationHandleParts = operationHandleStr.split("\\|")
+      require(
+        operationHandleParts.size == 4,
+        s"Expected 4 parameters but found ${operationHandleParts.size}.")
+
+      val handleIdentifier = new HandleIdentifier(

Review comment:
       let have a `HandleIdentifier.apply(publicID: String, secretId: String): HandleIdentifier`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762823918



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/OperationsResource.scala
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.server.api.v1
+
+import javax.ws.rs.{GET, Path, PathParam, Produces, _}
+import javax.ws.rs.core.MediaType
+
+import scala.util.control.NonFatal
+
+import io.swagger.v3.oas.annotations.media.Content
+import io.swagger.v3.oas.annotations.responses.ApiResponse
+import io.swagger.v3.oas.annotations.tags.Tag
+
+import org.apache.kyuubi.server.api.ApiRequestContext
+
+@Tag(name = "Operation")
+@Produces(Array(MediaType.APPLICATION_JSON))
+private[v1] class OperationsResource extends ApiRequestContext {
+
+  @ApiResponse(
+    responseCode = "200",
+    content = Array(new Content(
+      mediaType = MediaType.APPLICATION_JSON)),
+    description =
+      "Get an operation detail with a given session identifier and operation identifier")
+  @GET
+  @Path("{operationHandle}")
+  def getOperationHandle(
+      @PathParam("operationHandle") operationHandleStr: String): OperationDetail = {
+    try {
+      val operationManager = backendService.sessionManager.operationManager
+      val operationHandle = operationManager.parseOperationHandle(operationHandleStr)
+      val operation = operationManager.getOperation(operationHandle)
+      OperationDetail(operation.shouldRunAsync, operation.isTimedOut, operation.getStatus)
+    } catch {
+      case NonFatal(_) =>
+        throw new NotFoundException(s"Error closing an operation")

Review comment:
       'Error closing an operation'?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762821798



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/operation/OperationManager.scala
##########
@@ -137,4 +142,23 @@ abstract class OperationManager(name: String) extends AbstractService(name) {
       }
     }
   }
+
+  def parseOperationHandle(operationHandleStr: String): OperationHandle = {

Review comment:
       lets move it to `object OperationHandle`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762825123



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -283,4 +286,22 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
       timeoutChecker.scheduleWithFixedDelay(checkTask, interval, interval, TimeUnit.MILLISECONDS)
     }
   }
+
+  def parseSessionHandle(sessionHandleStr: String): SessionHandle = {
+    try {
+      val sessionHandleParts = sessionHandleStr.split("\\|")
+      require(
+        sessionHandleParts.size == 3,
+        s"Expected 4 parameters but found ${sessionHandleParts.size}.")
+
+      val handleIdentifier = new HandleIdentifier(
+        UUID.fromString(sessionHandleParts(0)),
+        UUID.fromString(sessionHandleParts(1)))
+      val protocolVersion = TProtocolVersion.findByValue(sessionHandleParts(2).toInt)
+      new SessionHandle(handleIdentifier, protocolVersion)
+    } catch {
+      case NonFatal(_) =>
+        throw KyuubiSQLException(s"Invalid $sessionHandleStr")

Review comment:
       Does it seem to hide the root cause here? Shall we remove the entire `try-catch` or wrap for reason




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#issuecomment-986627801


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1502](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b1b64) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/73ac1b63dbab7e46b34a495f4cdf17211c4f99af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73ac1b6) will **decrease** coverage by `0.16%`.
   > The diff coverage is `50.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1502      +/-   ##
   ============================================
   - Coverage     59.38%   59.22%   -0.17%     
     Complexity      172      172              
   ============================================
     Files           237      239       +2     
     Lines         12168    12161       -7     
     Branches       1492     1492              
   ============================================
   - Hits           7226     7202      -24     
   - Misses         4331     4349      +18     
   + Partials        611      610       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/kyuubi/operation/OperationHandle.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vT3BlcmF0aW9uSGFuZGxlLnNjYWxh) | `67.44% <0.00%> (-29.23%)` | :arrow_down: |
   | [...cala/org/apache/kyuubi/session/SessionHandle.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25IYW5kbGUuc2NhbGE=) | `46.42% <0.00%> (-34.83%)` | :arrow_down: |
   | [...ache/kyuubi/server/api/v1/OperationsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL09wZXJhdGlvbnNSZXNvdXJjZS5zY2FsYQ==) | `85.71% <85.71%> (ø)` | |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `44.44% <100.00%> (+6.94%)` | :arrow_up: |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `78.78% <100.00%> (-0.35%)` | :arrow_down: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `81.57% <0.00%> (-2.64%)` | :arrow_down: |
   | [.../org/apache/kyuubi/ha/client/ServiceNodeInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlTm9kZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `92.59% <0.00%> (+3.70%)` | :arrow_up: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `47.27% <0.00%> (+6.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [73ac1b6...c4b1b64](https://codecov.io/gh/apache/incubator-kyuubi/pull/1502?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#discussion_r762822368



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -283,4 +286,22 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
       timeoutChecker.scheduleWithFixedDelay(checkTask, interval, interval, TimeUnit.MILLISECONDS)
     }
   }
+
+  def parseSessionHandle(sessionHandleStr: String): SessionHandle = {
+    try {
+      val sessionHandleParts = sessionHandleStr.split("\\|")
+      require(
+        sessionHandleParts.size == 3,
+        s"Expected 4 parameters but found ${sessionHandleParts.size}.")

Review comment:
       Expected 4 -> 3




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502#issuecomment-986741002


   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1502: [KYUUBI #1501] Introduce operationsResource

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1502:
URL: https://github.com/apache/incubator-kyuubi/pull/1502


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org