You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/22 14:12:48 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1153: DO NOT MERGE - extend travis timeouts hugely
kgiusti opened a new pull request #1153:
URL: https://github.com/apache/qpid-dispatch/pull/1153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1153: DO NOT MERGE - extend travis timeouts hugely
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1153:
URL: https://github.com/apache/qpid-dispatch/pull/1153#discussion_r618456683
##########
File path: .travis.yml
##########
@@ -204,7 +212,7 @@ script:
- popd
# Workaround on macOS for PROTON-808 Binaries have their library locations stripped
- if [[ "${OSTYPE}" == "darwin"* ]]; then install_name_tool -add_rpath $PREFIX/lib/. $PREFIX/lib/proton/bindings/python/_cproton.so; fi
-- ctest -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = "Coverage" ]; then cmake --build . --target coverage; fi
+- ctest --timeout 1200 -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = "Coverage" ]; then cmake --build . --target coverage; fi
Review comment:
Good point. The 300 second (5 minute) per-test timeout would trigger first I believe, since each test prints something at the start and end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1153: DO NOT MERGE - extend travis timeouts hugely
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1153:
URL: https://github.com/apache/qpid-dispatch/pull/1153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1153: DO NOT MERGE - extend travis timeouts hugely
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1153:
URL: https://github.com/apache/qpid-dispatch/pull/1153#discussion_r618452376
##########
File path: .travis.yml
##########
@@ -204,7 +212,7 @@ script:
- popd
# Workaround on macOS for PROTON-808 Binaries have their library locations stripped
- if [[ "${OSTYPE}" == "darwin"* ]]; then install_name_tool -add_rpath $PREFIX/lib/. $PREFIX/lib/proton/bindings/python/_cproton.so; fi
-- ctest -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = "Coverage" ]; then cmake --build . --target coverage; fi
+- ctest --timeout 1200 -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = "Coverage" ]; then cmake --build . --target coverage; fi
Review comment:
Let's not forget that there is a Travis timeout which kills a build if it has not produced any output for 10 minutes. With a big timeout like this, what can happen is that if a test gets stuck, the first thing that triggers is the Travis timeout and that kills the entire CI job.
Solution would be to play with timeouts more, or run a background process that is printing dots every 5 minutes or so... Lets see if we actually hit this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org