You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/14 07:04:05 UTC
[GitHub] [nifi] s9514171 opened a new pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
s9514171 opened a new pull request #4407:
URL: https://github.com/apache/nifi/pull/4407
… the flow
#### Description of PR
When we're using registry to update the flow, there are some unnecessary behavior stop and start processors.
such as
processor: color style, position changes
connection: bend points changed
This PR is used to remove these kind of behaviors
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#issuecomment-826170738
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] patricker commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
patricker commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r492747448
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
@s9514171 The name of this variable is confusing. Your comment says, "true if the difference can NOT be modified". Can you include NOT in the variable name? Right now it sounds like the opposite.
`FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE = (fd) -> isModifiableInRunningState(fd);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] patricker commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
patricker commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r492747448
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
@s9514171 The name of this variable is confusing. Your comment says, "true if the difference can NOT be modified". Can you include NOT in the variable name? Right now it sounds like the opposite.
`FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE = (fd) -> isModifiableInRunningState(fd);`
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
@s9514171 The name of this variable is confusing. Your comment says, "true if the difference can NOT be modified". Can you include NOT in the variable name? Right now it sounds like the opposite.
`FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#issuecomment-826170738
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r493249294
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
Yes, the variable named incorrectly and should be changed to FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE
let me modify it.
Thanks 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r493263483
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
Added a commit for wrong variable naming, thanks for your review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] patricker commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
patricker commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r492747448
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
return false;
}
+ /**
+ * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+ */
+ public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);
Review comment:
@s9514171 The name of this variable is confusing. Your comment says, "true if the difference can NOT be modified". Can you include NOT in the variable name? Right now it sounds like the opposite.
`FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4407:
URL: https://github.com/apache/nifi/pull/4407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org