You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "朱亚东 (JIRA)" <xe...@xml.apache.org> on 2012/11/24 15:14:57 UTC

[jira] [Created] (XERCESC-2004) bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern

朱亚东 created XERCESC-2004:
----------------------------

             Summary: bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern 
                 Key: XERCESC-2004
                 URL: https://issues.apache.org/jira/browse/XERCESC-2004
             Project: Xerces-C++
          Issue Type: Bug
          Components: DOM
    Affects Versions: 3.1.1
         Environment: any
            Reporter: 朱亚东


code like below:
short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
    if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
        pattern &= !DOMNode::DOCUMENT_POSITION_PRECEDING;
        pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
    }
I think it should be:
short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
    if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
        pattern &= ~DOMNode::DOCUMENT_POSITION_PRECEDING;
        pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
    }
because !DOMNode::DOCUMENT_POSITION_PRECEDING always be 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org

[jira] [Resolved] (XERCESC-2004) bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern

Posted by "Alberto Massari (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESC-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alberto Massari resolved XERCESC-2004.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.0
         Assignee: Alberto Massari

Thanks for spotting this; the fix is now in SVN
                
> bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern 
> ---------------------------------------------------------------
>
>                 Key: XERCESC-2004
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2004
>             Project: Xerces-C++
>          Issue Type: Bug
>          Components: DOM
>    Affects Versions: 3.1.1
>         Environment: any
>            Reporter: 朱亚东
>            Assignee: Alberto Massari
>             Fix For: 3.2.0
>
>
> code like below:
> short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
>     if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
>         pattern &= !DOMNode::DOCUMENT_POSITION_PRECEDING;
>         pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
>     }
> I think it should be:
> short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
>     if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
>         pattern &= ~DOMNode::DOCUMENT_POSITION_PRECEDING;
>         pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
>     }
> because !DOMNode::DOCUMENT_POSITION_PRECEDING always be 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org