You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by brian Foster <ho...@juno.com> on 2012/03/18 22:22:42 UTC

Review Request: Port LoggerOutputStream in CAS-PGE to existing LoggerOutputStream in oodt-commons io package

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4398/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.


Summary
-------

This is the CAS-PGE portion of this change


This addresses bug OODT-423.
    https://issues.apache.org/jira/browse/OODT-423


Diffs
-----

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1302224 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java 1302224 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java 1302224 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302224 
  trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java 1302224 

Diff: https://reviews.apache.org/r/4398/diff


Testing
-------

updated/added unit-tests


Thanks,

brian


Re: Review Request: Port LoggerOutputStream in CAS-PGE to existing LoggerOutputStream in oodt-commons io package (CAS-PGE changes)

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4398/#review6072
-----------------------------------------------------------

Ship it!


LGTM!

- Chris


On 2012-03-18 21:25:45, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4398/
> -----------------------------------------------------------
> 
> (Updated 2012-03-18 21:25:45)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Summary
> -------
> 
> This is the CAS-PGE portion of this change
> 
> 
> This addresses bug OODT-423.
>     https://issues.apache.org/jira/browse/OODT-423
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1302224 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java 1302224 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java 1302224 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302224 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java 1302224 
> 
> Diff: https://reviews.apache.org/r/4398/diff
> 
> 
> Testing
> -------
> 
> updated/added unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>


Re: Review Request: Port LoggerOutputStream in CAS-PGE to existing LoggerOutputStream in oodt-commons io package (CAS-PGE changes)

Posted by brian Foster <ho...@juno.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4398/
-----------------------------------------------------------

(Updated 2012-03-18 21:25:45.978379)


Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.


Summary (updated)
-------

This is the CAS-PGE portion of this change


This addresses bug OODT-423.
    https://issues.apache.org/jira/browse/OODT-423


Diffs
-----

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1302224 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java 1302224 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java 1302224 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302224 
  trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java 1302224 

Diff: https://reviews.apache.org/r/4398/diff


Testing
-------

updated/added unit-tests


Thanks,

brian