You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2016/07/01 00:51:41 UTC

[GitHub] spark issue #13997: [SPARK-16328][ML][MLLIB][PYSPARK] Add 'asML' and 'fromML...

Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/13997
  
    Thanks for the updates!  For tests, I'm all for including some doc tests in Python if they provide good examples for the docs.  But developers, myself included, have tended to include too much in doc tests in the past.
    
    LGTM
    Merging with master and branch-2.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org