You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/05/20 08:27:17 UTC

[GitHub] codecov-io commented on issue #1820: Improve graceful shutdown

codecov-io commented on issue #1820: Improve graceful shutdown
URL: https://github.com/apache/incubator-dubbo/pull/1820#issuecomment-390465824
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=h1) Report
   > Merging [#1820](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5a3b1553dda84dc6e73e918bb6e025764d8c9a63?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/graphs/tree.svg?token=VnEIkiFQT0&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #1820      +/-   ##
   ===========================================
   - Coverage     40.43%   40.4%   -0.04%     
   - Complexity     4415    4416       +1     
   ===========================================
     Files           628     629       +1     
     Lines         30081   30108      +27     
     Branches       5320    5322       +2     
   ===========================================
     Hits          12164   12164              
   - Misses        15993   16015      +22     
   - Partials       1924    1929       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../java/com/alibaba/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `73.48% <0%> (-1.14%)` | `59 <0> (ø)` | |
   | [.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `73.3% <100%> (+0.09%)` | `116 <0> (ø)` | :arrow_down: |
   | [...libaba/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb250YWluZXIvc3ByaW5nL1NwcmluZ0NvbnRhaW5lci5qYXZh) | `72.22% <100%> (+1.63%)` | `4 <0> (ø)` | :arrow_down: |
   | [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `43.47% <43.47%> (ø)` | `5 <5> (?)` | |
   | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | |
   | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
   | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
   | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0%> (-1.87%)` | `15% <0%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=footer). Last update [5a3b155...8e822e1](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org