You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/05 19:18:51 UTC
[GitHub] [buildstream-plugins] nanonyme opened a new pull request, #23: Port make-args feature from make to autotools
nanonyme opened a new pull request, #23:
URL: https://github.com/apache/buildstream-plugins/pull/23
This is important not just for plain makefile elements but
also for autotools elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23#issuecomment-1206785190
I will add documentation once sure this will not change cache keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23#issuecomment-1214209125
There's some random failure from Docker source tests. I suspect the bug there is they are using Docker Hub as input. That is a completely unreliable source for any CI needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23#issuecomment-1213403409
> Maybe this is not worth it if this breaks cache keys.
We’re already breaking keys, and it’s our last chance, this looks like something better to have than not have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23#issuecomment-1213377749
Maybe this is not worth it if this breaks cache keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23#issuecomment-1213459165
Okay, I will have another look at this once build-dir PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan merged pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #23:
URL: https://github.com/apache/buildstream-plugins/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme closed pull request #23: Port make-args feature from make to autotools
Posted by GitBox <gi...@apache.org>.
nanonyme closed pull request #23: Port make-args feature from make to autotools
URL: https://github.com/apache/buildstream-plugins/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org