You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/10/17 10:49:16 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #1056: nimble/phy/nrf: Fix checking for resolved addr
andrzej-kaczmarek opened a new pull request #1056:
URL: https://github.com/apache/mynewt-nimble/pull/1056
We should check if NRF_AAR was enabled prior to checking its result
to avoid reading some uninitialied values if resolver was not enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1056: nimble/phy/nrf: Fix checking for resolved addr
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #1056:
URL: https://github.com/apache/mynewt-nimble/pull/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1056: nimble/phy/nrf: Fix checking for resolved addr
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #1056:
URL: https://github.com/apache/mynewt-nimble/pull/1056#issuecomment-945091864
I am not really sure why current code actually works, but noticed this on qualification test cases after some changes in initiator code as it started hitting this assert: https://github.com/apache/mynewt-nimble/blob/master/nimble/controller/src/ble_ll_scan.c#L1836 (in this particular case static random address was somehow "resolved").
This was likely triggered by the fact that address resolution was disabled, but the previous iteration enabled encryption and this apparently messed up NRF_AAR registers, I think because it shares AES block with NRF_CCM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org