You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/03/05 09:39:05 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

eladkal commented on code in PR #29909:
URL: https://github.com/apache/airflow/pull/29909#discussion_r1125630661


##########
airflow/timetables/simple.py:
##########
@@ -108,6 +109,37 @@ def next_dagrun_info(
         return DagRunInfo.exact(run_after)
 
 
+class ContinuousTimetable(_TrivialTimetable):
+    """Timetable that schedules continually, while still respecting start_date and end_date
+
+    This corresponds to ``schedule="@continuous"``.
+    """
+
+    description: str = "As frequently as possible while still obeying max_active_runs"

Review Comment:
   > I'd say the only real good use case for continuous is with max_active_run =1 and we should limit it to only that.
   
   I agree. I'm pretty sure that users who use the current workaround also explicitly set `max_active_run=1`  in their dag.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org